Re: [PATCH] D16377: Ensure virtual-near-miss does not crash on functions without names

2016-01-23 Thread Aaron Ballman via cfe-commits
aaron.ballman abandoned this revision. aaron.ballman added a comment. You are correct, this was fixed with http://reviews.llvm.org/D16179. Thanks! http://reviews.llvm.org/D16377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

Re: [PATCH] D16377: Ensure virtual-near-miss does not crash on functions without names

2016-01-22 Thread Alexander Kornienko via cfe-commits
alexfh added a subscriber: alexfh. alexfh added a comment. Should be fixed in http://reviews.llvm.org/D16179. http://reviews.llvm.org/D16377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D16377: Ensure virtual-near-miss does not crash on functions without names

2016-01-22 Thread Alexander Kornienko via cfe-commits
Should be fixed in http://reviews.llvm.org/D16179. On Jan 20, 2016 23:55, "Aaron Ballman" wrote: > aaron.ballman updated this revision to Diff 45451. > aaron.ballman added a comment. > > Now checking that both the base *and* the derived functions have names. > > > http://reviews.llvm.org/D16377 >

Re: [PATCH] D16377: Ensure virtual-near-miss does not crash on functions without names

2016-01-20 Thread Aaron Ballman via cfe-commits
aaron.ballman updated this revision to Diff 45451. aaron.ballman added a comment. Now checking that both the base *and* the derived functions have names. http://reviews.llvm.org/D16377 Files: clang-tidy/misc/VirtualNearMissCheck.cpp test/clang-tidy/misc-virtual-near-miss.cpp Index: test/cl

[PATCH] D16377: Ensure virtual-near-miss does not crash on functions without names

2016-01-20 Thread Aaron Ballman via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: congliu, alexfh. aaron.ballman added a subscriber: cfe-commits. Special member functions don't always have names, and so calling FunctionDecl::getName() can cause assertions. This patch addresses the issue by assuming any such f