aaron.ballman closed this revision.
aaron.ballman added a comment.
Thanks! I've commit in r258213.
http://reviews.llvm.org/D16301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sberg updated this revision to Diff 45310.
sberg added a comment.
oops, had erroneously based it on some other local patch; rebased now
http://reviews.llvm.org/D16301
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/AttributeList.h
lib/Sem
aaron.ballman added a comment.
Can you please rebase this off ToT and upload the latest diff? This is not
applying cleanly for me.
http://reviews.llvm.org/D16301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
sberg added a comment.
Please somebody push this for me; I don't have commit access. Thanks
http://reviews.llvm.org/D16301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for fixing this!
http://reviews.llvm.org/D16301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
sberg updated this revision to Diff 45268.
sberg added a comment.
updated the diagnostic message to mention fields in addition to variables and
typedefs
http://reviews.llvm.org/D16301
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Attribu
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:891
@@ -891,2 +890,3 @@
+ let Subjects = SubjectList<[Var, TypedefName, Field], ErrorDiag,
"ExpectedVariableOrTypedef">;
let Args = [IdentifierArgument<"Mode">];
sberg created this revision.
sberg added reviewers: ABataev, aaron.ballman.
sberg added a subscriber: cfe-commits.
...after r257868 "PR26111: segmentation fault with __attribute__((mode(QI))) on
function declaration" (presumably accidentally) restricted it to variables and
typedefs, excluding me
