MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/Driver/ToolChains/UEFI.cpp:68
+ // "Terminal Service Aware" flag is not needed for UEFI applications.
+ CmdArgs.push_back("-tsaware:no
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159541/new/
https://reviews.llvm.org/D159541
___
Prabhuk updated this revision to Diff 557372.
Prabhuk added a comment.
Removed IsIntegratedAssemblerDefault.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159541/new/
https://reviews.llvm.org/D159541
Files:
clang/lib/Basic/Targets.cpp
clang/li
brad added inline comments.
Comment at: clang/lib/Driver/ToolChains/UEFI.h:46
+ bool HasNativeLLVMSupport() const override { return true; }
+ bool IsIntegratedAssemblerDefault() const override { return true; }
+ UnwindTableLevel
Remove the IsIntegratedAssemble
Prabhuk updated this revision to Diff 557227.
Prabhuk added a comment.
Addressed review comments about the inline comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159541/new/
https://reviews.llvm.org/D159541
Files:
clang/lib/Basic/Targets
phosek added inline comments.
Comment at: clang/lib/Driver/ToolChains/UEFI.cpp:58-59
+
+ // Other UEFI binary subsystems that are currently unsupported:
+ // efi_boot_service_driver, efi_rom, efi_runtime_driver.
+ CmdArgs.push_back("-subsystem:efi_application");
--
Prabhuk created this revision.
Prabhuk added a reviewer: phosek.
Herald added a subscriber: pengfei.
Herald added a project: All.
Prabhuk requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
Introduce changes necessary for UEFI X86_64 ta
