[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

usaxena95 closed this revision. usaxena95 added a comment. closed by ac2d2652db8de9ea2b750dd2bf1232941039dffe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158842/new/ https://r

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LGTM Unclear to me whether the FIXME will be addressed by an AST bug or a local change, either way continuing to look into it SG but this is fine to land as-is. Repository: rG LLVM G

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

usaxena95 updated this revision to Diff 554962. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158842/new/ https://reviews.llvm.org/D158842 Files: clang-to

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:244 + bool VisitConceptDecl(ConceptDecl *CD) { +report(CD->getLocation(), CD); I don't know why we're doing this, decls in general are not considered references

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

usaxena95 added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp:217 +void $2^func2() requires $Bar4^Bar {} + )cpp"); + Inputs.Code = Code.code(); sammccall wrote: > to complete the set I think you want > > `void fo

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

usaxena95 updated this revision to Diff 554955. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Rebased over AST changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158842/new/ https://reviews.llvm.org/D158842 Files: cl

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

sammccall added a comment. I think we're not *that* far away from landing the AST change, and changing RecursiveASTVisitor now is probably confusing and not worth the churn. So I'd prefer to wait for now... Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:240 + +

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

usaxena95 created this revision. usaxena95 added reviewers: massberg, sammccall. Herald added a subscriber: kadircet. Herald added a project: All. usaxena95 requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This is similar t