[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGef2b1700f464: [Sema][HLSL] Consolidate handling of HLSL attributes (authored by bogner). Changed prior to commit: https://reviews.llvm.org/D158803?vs=554044&id=554379#toc Repository: rG LLVM Github M

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12395-12398 + // TODO: This should probably just be llvm_unreachable and we should + // reject triples with random ABIs and such when we build the target. + // For now, crash. + llvm::report

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158803/new/ https://reviews.llvm.org/D158803 ___ cfe-commits mailing list cfe-comm

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner updated this revision to Diff 554044. bogner added a comment. - Now with more const - Added DiagnoseHLSLAttrStageMismatch and avoided using raw strings in diagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158803/new/ https://reviews

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12395-12398 + // TODO: This should probably just be llvm_unreachable and we should + // reject triples with random ABIs and such when we build the target. + // For now, crash. + llvm:

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12395-12398 + // TODO: This should probably just be llvm_unreachable and we should + // reject triples with random ABIs and such when we build the target. + // For now, crash. + llvm::report

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3008-3011 + void ActOnHLSLTopLevelFunction(FunctionDecl *FD); void CheckHLSLEntryPoint(FunctionDecl *FD); + void CheckHLSLSemanticAnnotation(FunctionDecl *EntryPoint, Decl *Param, +

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner updated this revision to Diff 553964. bogner added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158803/new/ https://reviews.llvm.org/D158803 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/Diagnosti

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner updated this revision to Diff 553395. bogner added a comment. Broke out a couple of semi-unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158803/new/ https://reviews.llvm.org/D158803 Files: clang/include/clang/Basic/Attr.td

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner created this revision. bogner added reviewers: beanz, python3kgae, bob80905, tex3d. Herald added subscribers: Anastasia, arphaman, mcrosier. Herald added a reviewer: aaron.ballman. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald ad