[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

MaskRay added a comment. > Make "-fno-split-machine-functions" a valid flag for all archs. Driver changes usually are named `[Driver] ...`. The popular convention is to omit the full stop at the end of the subject. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. With a test nit Comment at: clang/test/Driver/fsplit-machine-functions.c:19 +// RUN: not %clang -### -x cuda -S -nocudainc -nocudalib -fsplit-machine-functions %s 2>&1 | F

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions.c:19 +// RUN: not %clang -### -x cuda -S -nocudainc -nocudalib -fsplit-machine-functions %s 2>&1 | FileCheck %s --check-prefix=ERR2 +// ERR2: clang: error: unsupported option '-fsplit-machine-f

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan updated this revision to Diff 553256. shenhan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158755/new/ https://reviews.llvm.org/D158755 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/fsp

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

MaskRay added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions.c:19 +// RUN: not %clang -### -x cuda -S -nocudainc -nocudalib -fsplit-machine-functions %s 2>&1 | FileCheck %s --check-prefix=ERR2 +// ERR2: clang: error: unsupported option '-fsplit-machine-f

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan added a comment. In D158755#4614566 , @MaskRay wrote: > Thanks for the patch. We need a test. I cleaned up > `fsplit-machine-functions.c` a bit. You can rebase and modify the `not %clang > -### -c --target=arm-unknown-linux -fsplit-machine-funct

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan updated this revision to Diff 553219. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158755/new/ https://reviews.llvm.org/D158755 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/fsplit-machine-functions.c Index: clang/tes

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

MaskRay added a comment. Thanks for the patch. We need a test. I cleaned up `fsplit-machine-functions.c` a bit. You can rebase and modify the `not %clang -### -c --target=arm-unknown-linux -fsplit-machine-functions -fno-split-machine-functions` RUN line in `clang/test/Driver/fsplit-machine-fun

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan created this revision. shenhan added a reviewer: MaskRay. Herald added a subscriber: pengfei. Herald added a project: All. shenhan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, when clang reports an error when -fno-spl