[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbeb3d029d8e: Add missing vrnd intrinsics (authored by miyengar, committed by vhscampos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158626/new/ https://reviews.llvm.org/D158626 ___ cfe-commits mailing list cfe

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

miyengar added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:6309 + + def : Pat<(v1f64 (OpNode (v1f64 FPR64:$Rn))), + (!cast(NAME # Dr) FPR64:$Rn)>; dmgreen wrote: > miyengar wrote: > > dmgreen wrote: > > > I think the ins

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

miyengar updated this revision to Diff 556170. miyengar added a comment. Moved pattern from `AArchInstrFormats.td` to `AArchInstrInfo.td` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158626/new/ https://reviews.llvm.org/D158626 Files: clang/include/clang/Basic/arm_neon.td clang/li

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

dmgreen added a comment. Other than where the pattern gets defined this looks OK to me. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:6309 + + def : Pat<(v1f64 (OpNode (v1f64 FPR64:$Rn))), + (!cast(NAME # Dr) FPR64:$Rn)>; miyengar wrote:

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

miyengar added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:6309 + + def : Pat<(v1f64 (OpNode (v1f64 FPR64:$Rn))), + (!cast(NAME # Dr) FPR64:$Rn)>; dmgreen wrote: > I think the instructions in this multiclass are the vect

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

miyengar updated this revision to Diff 555879. miyengar marked an inline comment as done. miyengar added a comment. Moved v1f64 -> Dr (Vector to Scalar) Pattern from `SIMDTwoVectorSD` to `FRIntNNTVector` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158626/new/ https://reviews.llvm.org

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:6309 + + def : Pat<(v1f64 (OpNode (v1f64 FPR64:$Rn))), + (!cast(NAME # Dr) FPR64:$Rn)>; I think the instructions in this multiclass are the vector variants. Can t

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

miyengar marked an inline comment as done. miyengar added a comment. Thank you for the feedback! I've added an amended patch using the pre-existing instruction. Also, I've tried to submit the patch with context this time. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

miyengar updated this revision to Diff 553104. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158626/new/ https://reviews.llvm.org/D158626 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/aarch64-v

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

dmgreen added a comment. Sounds good. Can you make sure you upload with context, it makes the patches easier to read in phabricator: https://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:6297

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

miyengar created this revision. miyengar added a reviewer: vhscampos. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. miyengar requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch add