[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

kadircet added a comment. hi @hiraditya , i believe your issues should disappear starting with 9a26d2c6d35f574d7a4b06a5a22f8a1c063cb664 . LMK if you're still facing problems and want to move forward with such a patch CHANGES

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

hiraditya added a comment. In D158566#4633847 , @kadircet wrote: > In D158566#4616417 , @ilya-biryukov > wrote: > >> Open question: I also feel like the best option here is to fix the tests, >> but I'm not sure

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

kadircet added a comment. In D158566#4616417 , @ilya-biryukov wrote: > Open question: I also feel like the best option here is to fix the tests, but > I'm not sure how hard that would be. @sammccall any thoughts? > I suspect the particular tests are fla

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

hiraditya added a comment. > I'm marking as requiring changes mostly for the latter comment about > CLANG_INCLUDE_TESTS. Added CLANG_INCLUDE_TESTS to the conditional. btw when CLANG_INCLUDE_TESTS is OFF, `ninja check-clang-tools` target doesn't get created so adding CLANG_INCLUDE_TESTS here di

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

hiraditya updated this revision to Diff 553738. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158566/new/ https://reviews.llvm.org/D158566 Files: clang-tools-extra/clangd/CMakeLists.txt Index: clang-tools-extra/clangd/CMakeLists.txt ===

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

ilya-biryukov requested changes to this revision. ilya-biryukov added a subscriber: sammccall. ilya-biryukov added a comment. This revision now requires changes to proceed. Open question: I also feel like the best option here is to fix the tests, but I'm not sure how hard that would be. @sammccal

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. I'm not entirely convinced by the motivation (wouldn't it be better to just fix the tests?), but this seems like a perfectly reasonable flag to have. CHANGES SINCE LAST ACTION https://revie

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

hiraditya added a subscriber: nridge. hiraditya added a comment. Added previously reported issues shared by @nridge CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158566/new/ https://reviews.llvm.org/D158566 ___ cfe-commits mailing list cfe-co

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

hiraditya updated this revision to Diff 552543. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158566/new/ https://reviews.llvm.org/D158566 Files: clang-tools-extra/clangd/CMakeLists.txt Index: clang-to