[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

2023-08-22 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D158559#4608410 , @ivanrodriguez3753 wrote: > Also, should the underlying issue and test case be filed as an issue on > Github? I wasn't sure since this revision includes the bug and a description If you're going to fix this

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

2023-08-22 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D158559#4608397 , @ivanrodriguez3753 wrote: > In D158559#4608388 , @ABataev wrote: > >> 1. Always provide full context in the patch. > > Sure, would you mind mentioning what's missing?

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

2023-08-22 Thread Ivan Rodriguez via Phabricator via cfe-commits
ivanrodriguez3753 added a comment. Also, should the underlying issue and test case be filed as an issue on Github? I wasn't sure since this revision includes the bug and a description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158559/new/ https

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

2023-08-22 Thread Ivan Rodriguez via Phabricator via cfe-commits
ivanrodriguez3753 added a comment. In D158559#4608388 , @ABataev wrote: > 1. Always provide full context in the patch. Sure, would you mind mentioning what's missing? Or do you mean the stuff from debug output being shortened, as well as LLVM IR being o

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

2023-08-22 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. 1. Always provide full context in the patch. 2. It looks like we're counting the pointer size (or the size of just the first element of the array), because we do not account array section here, either just the pointer or the first element only (most probably second opti

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

2023-08-22 Thread Ivan Rodriguez via Phabricator via cfe-commits
ivanrodriguez3753 created this revision. ivanrodriguez3753 added a reviewer: OpenMP. Herald added subscribers: pengfei, guansong, tpr, yaxunl. Herald added a project: All. ivanrodriguez3753 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits,