[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a comment. In D158476#4647652 , @MaskRay wrote: > nits Sorry, this came in right as I committed the diff. I pushed rG915ebb07dfc53486eccf0dc09b6411929a463e98 to addres

[PATCH] D158476: [driver] Search for compatible Android runtime directories

This revision was automatically updated to reflect the committed changes. Closed by commit rG58288c6c1214: [driver] Search for compatible Android runtime directories (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158476/new/ ht

[PATCH] D158476: [driver] Search for compatible Android runtime directories

MaskRay accepted this revision. MaskRay added a comment. nits Comment at: clang/docs/ReleaseNotes.rst:295 + target-specific runtime and standard libraries in directories named after the + target (e.g. if you're building with ``-target aarch64-none-linux-android21``, + Clang

[PATCH] D158476: [driver] Search for compatible Android runtime directories

pirama accepted this revision. pirama added a comment. LGTM from the Android platform/NDK side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158476/new/ https://reviews.llvm.org/D158476 ___ cfe-commits

[PATCH] D158476: [driver] Search for compatible Android runtime directories

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158476/new/ https://reviews.llvm.org/D158476 ___

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158476/new/ https://reviews.llvm.org/D158476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a comment. Ping. I added the warning and release note. I haven't made search paths be dumped in `-v` mode because I thought it could be pretty noisy (especially since you'll be doing three searches, for resource dir libraries, libc++ per-target headers, and non-resource dir librar

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai updated this revision to Diff 555213. smeenai added a comment. Add warning and release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158476/new/ https://reviews.llvm.org/D158476 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a comment. In D158476#4632188 , @thakis wrote: > Works for me. How do you imagine the transition happening? Should we emit > some kind of warning if the old fallback is hit? That's a good call. I'll add that plus a release note. Reposito

[PATCH] D158476: [driver] Search for compatible Android runtime directories

thakis added a comment. Works for me. How do you imagine the transition happening? Should we emit some kind of warning if the old fallback is hit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158476/new/ https://reviews.llvm.org/D158476

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a reviewer: glandium. smeenai added a comment. @thakis I'm inclined to leave the fallback for a triple without any version in place for now, since it seems like Mozilla might be relying on it too, and we can remove it once everyone's moved over to the new fallback mechanism. What d

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai updated this revision to Diff 555086. smeenai added a comment. Kick off pre-merge checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158476/new/ https://reviews.llvm.org/D158476 Files: clang/include/clang/Driver/ToolChain.h clang/lib

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai updated this revision to Diff 555082. smeenai added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158476/new/ https://reviews.llvm.org/D158476 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.c

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a comment. D158798 demonstrates a working Android runtimes setup with per-target runtime directories once this change is in place. It'll be nicer once D140925 lands, but it's workable even without that. Reposi

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai updated this revision to Diff 553291. smeenai added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158476/new/ https://reviews.llvm.org/D158476 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.c

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a comment. In D158476#4609243 , @srhines wrote: > This approach LGTM, assuming that https://reviews.llvm.org/D140925 lands as > well to ensure that the triple does use `androideabi`, since it would prevent > custom build setups from needin

[PATCH] D158476: [driver] Search for compatible Android runtime directories

srhines added a comment. This approach LGTM, assuming that https://reviews.llvm.org/D140925 lands as well to ensure that the triple does use `androideabi`, since it would prevent custom build setups from needing additional help. > (Aside: why do we need to produce runtime libraries for differen

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a comment. In D158476#4608428 , @thakis wrote: > I think this is a useful feature, for the reasons mentioned on the thread. > > Since this is a superset of D115049 (... > right?), this should probably reve

[PATCH] D158476: [driver] Search for compatible Android runtime directories

thakis added a comment. I think this is a useful feature, for the reasons mentioned on the thread. Since this is a superset of D115049 (... right?), this should probably revert the changes over there? Maybe we should dump searched paths in `-v` mode? Reposit

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a comment. In D158476#4605360 , @MaskRay wrote: >> // Android target triples contain a target version. If we don't have >> libraries for the exact target version, we should fall back to the next >> newest version or a versionless path, if

[PATCH] D158476: [driver] Search for compatible Android runtime directories

MaskRay added a comment. > // Android target triples contain a target version. If we don't have > libraries for the exact target version, we should fall back to the next > newest version or a versionless path, if any. An Android maintainer can override my opinion but my feeling is that this ad

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai created this revision. smeenai added reviewers: collinbaker, thakis, MaskRay, phosek, danalbert, srhines. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: All. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: c