[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

smeenai added a comment. In D158475#4626856 , @glandium wrote: > In D158475#4626636 , @smeenai wrote: > >> I'm halfway through an implementation of this, but I just realized that on >> Android, Clang never search

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

glandium added a comment. In D158475#4626636 , @smeenai wrote: > I'm halfway through an implementation of this, but I just realized that on > Android, Clang never searches for C++ headers installed alongside the driver: > https://github.com/llvm/llvm-pr

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

smeenai added a comment. In D158475#4623852 , @glandium wrote: > In D158475#4623842 , @smeenai wrote: > >> In D158475#4623471 , @glandium >> wrote: >> >>> This conflicts

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

glandium added a comment. In D158475#4623842 , @smeenai wrote: > In D158475#4623471 , @glandium > wrote: > >> This conflicts with D146664 > > It sounds like you want the same lo

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

smeenai added a comment. In D158475#4623471 , @glandium wrote: > This conflicts with D146664 It sounds like you want the same logic as D158476 to apply to the stdlib search as well as

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

glandium added a comment. This conflicts with D146664 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158475/new/ https://reviews.llvm.org/D158475 ___ cfe-commits mailing

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6a1473f97d3: [driver] Refactor getRuntimePaths. NFC (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158475/new/ https://reviews.llvm.org/D158475 ___

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

smeenai updated this revision to Diff 553290. smeenai added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158475/new/ https://reviews.llvm.org/D158475 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/Driver.cpp

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

smeenai created this revision. smeenai added reviewers: collinbaker, thakis, phosek, MaskRay. Herald added a project: All. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This used to be getRuntimePath till https://reviews.llvm.org/