This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG08f034f952fa: [clang][ExtractAPI] Add support for namespaces
(authored by evelez7).
Changed prior to commit:
https://reviews.llvm.org/D158239?vs=5
dang accepted this revision.
dang added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158239/new/
https://reviews.llvm.org/D158239
___
cfe
evelez7 updated this revision to Diff 552155.
evelez7 marked an inline comment as done.
evelez7 added a comment.
Move DetermineParentDecl to determineParentRecord in APIVisitor as a private
method.
Easier to just let it fetch the record for us and return nullptr if the parent
is the translation
dang added inline comments.
Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:38
+namespace {
+inline SmallString<128> DetermineParentDecl(const DeclContext *Context) {
+ SmallString<128> ParentUSR;
I think this should compute both the parent decl a
evelez7 updated this revision to Diff 551526.
evelez7 added a comment.
Revert extraneous formatting in API.h
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158239/new/
https://reviews.llvm.org/D158239
Files:
clang/include/clang/ExtractAPI/API.h
dang added inline comments.
Comment at: clang/include/clang/ExtractAPI/API.h:1129
template <>
-struct has_function_signature : public std::true_type
{};
+struct has_function_signature : public std::true_type
{
+};
Can we get rid of these types of changes to ke
evelez7 added a comment.
Note that this doesn't handle anonymous namespaces. Similar problems arise with
anonymous classes/structs, being worked on.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158239/new/
https://reviews.llvm.org/D158239
__
evelez7 updated this revision to Diff 551340.
evelez7 added a comment.
Remove unnecessary line break.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158239/new/
https://reviews.llvm.org/D158239
Files:
clang/include/clang/ExtractAPI/API.h
clang/
evelez7 created this revision.
evelez7 added a reviewer: dang.
Herald added a reviewer: ributzka.
Herald added a project: All.
evelez7 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Serialize namespaces, nested namespaces, and class relati
