[PATCH] D158152: [clang-tidy]mark record initList as non-const param

2023-08-21 Thread Congcong Cai via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c9412441b87: [clang-tidy]mark record initList as non-const param (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

2023-08-21 Thread Congcong Cai via Phabricator via cfe-commits
HerrCai0907 updated this revision to Diff 552199. HerrCai0907 added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158152/new/ https://reviews.llvm.org/D158152 Files: clang-tools-extra/clang-tidy/readability/NonConstParameterC

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

2023-08-21 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, but note that type aliases may not work properly, but that more a legacy issue that got source in line 104, simply because we should use canonical type there. Com

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

2023-08-19 Thread Congcong Cai via Phabricator via cfe-commits
HerrCai0907 updated this revision to Diff 551802. HerrCai0907 added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158152/new/ https://reviews.llvm.org/D158152 Files: clang-tools-extra/clang-tidy/readability/NonConstParameterC

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

2023-08-19 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:230 +- Improved :doc:`readability-non-const-parameter.cpp + ` check to ignore Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

2023-08-17 Thread Congcong Cai via Phabricator via cfe-commits
HerrCai0907 updated this revision to Diff 551344. HerrCai0907 added a comment. update release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158152/new/ https://reviews.llvm.org/D158152 Files: clang-tools-extra/clang-tidy/readability/NonCons

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

2023-08-17 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:234 +- Improved :doc:`readability-non-const-parameter.cpp + ` check to ignore Please keep alphabetical order (by check name) in this section. Repository: rG LLVM Gith

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

2023-08-17 Thread Congcong Cai via Phabricator via cfe-commits
HerrCai0907 updated this revision to Diff 551030. HerrCai0907 added a comment. add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158152/new/ https://reviews.llvm.org/D158152 Files: clang-tools-extra/clang-tidy/readability/NonConstPa

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

2023-08-17 Thread Congcong Cai via Phabricator via cfe-commits
HerrCai0907 created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang-tools-extra.