ealcdan added a comment.
Thanks for the review. How should I procceed? Should I remove the "Fixes:"
entry from the commit message?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157869/new/
https://reviews.llvm.org/D157869
PiotrZSL added a comment.
I agree that this change is an improvement that is welcome, but that's not a
fix for a #60217.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157869/new/
https://reviews.llvm.org/D157869
__
PiotrZSL added a comment.
This wont fix issue, simply because problem happen during reading -1, not
during dumping, and per documentation -1 was a valid value. Same issue happen
in other checks that use -1. Most probably best way would be to change those
variables into std::int64_t, in C++ crea
ealcdan created this revision.
Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
ealcdan requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Some options ta
