[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83a06997c69a: [flang][driver] Update the visibility of Clang options in Flang (authored by awarzynski). Changed prior to commit: https://reviews.l

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

awarzynski updated this revision to Diff 550668. awarzynski added a comment. Rebase on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157837/new/ https://reviews.llvm.org/D157837 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

tblah accepted this revision. tblah added a comment. Looks good to me, thanks for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157837/new/ https://reviews.llvm.org/D157837 ___ cfe-commits mailing

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

awarzynski updated this revision to Diff 550047. awarzynski added a comment. Add missing `TargetSpecific` flag to the definition of `mcpu_EQ`, remove redundant `TODO` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157837/new/ https://reviews.llvm.o

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

awarzynski marked 2 inline comments as done. awarzynski added a comment. Thank you all for reviewing! In D157837#4584387 , @bogner wrote: > I can't speak to which flags should be present in flang-new or not That's determined by what's tested/used in tes

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

DavidTruby added a comment. This looks good to me (minus the issue @tblah mentioned), while this will mean that we also error on gfortran options we don't recognize, I don't personally think that's a problem as in my personal experience Fortran users are used to different compilers accepting di

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

bogner added a comment. I can't speak to which flags should be present in flang-new or not, but in principle this looks great. You'll need to update the patch to use the "ClangOption" spelling rather than "Default" of course, as discussed in https://reviews.llvm.org/D157151

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

tblah added inline comments. Comment at: clang/lib/Driver/Driver.cpp:6472-6473 if (IsFlangMode()) { // TODO: Does flang really want *all* of the clang driver options? // We probably need to annotate more specifically. +return llvm::opt::Visibility(options::FlangO

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

awarzynski created this revision. awarzynski added a reviewer: bogner. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, wangpc, jplehr, sstefan1, jdoerfert, MaskRay. Herald added a reviewer: