kaz7 marked an inline comment as done.
kaz7 added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/VE.cpp:22
+ std::vector &Features) {
+ // Defaults.
+ bool EnableVPU = true;
MaskRay wrote:
> Delete the comment. The cod
kaz7 updated this revision to Diff 554528.
kaz7 added a comment.
Change to not control backend default bahavior but support VPU flag in
the backend for VE.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157813/new/
https://reviews.llvm.org/D157813
MaskRay added a comment.
> [VE][Clang] Change to enable VPU flag by default
For components like llvm/, clang/, we usually use a more specific tag. I'd pick
`[Driver]` over `[Clang]`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157813/new/
https
MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Driver/ToolChains/Arch/VE.cpp:22
+ std::vector &Features) {
+ // Defaults.
+ bool EnableVPU = true;
kaz7 added a comment.
Hi @MaskRay , thank you for reviewing this patch last time. Is it possible to
review updated this patch again? Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157813/new/
https://reviews.llvm.org/D157813
kaz7 marked 3 inline comments as done.
kaz7 added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157813/new/
https://reviews.llvm.org/D157813
___
cfe-commits mailing list
cfe-commits@lists
kaz7 marked 3 inline comments as done.
kaz7 added inline comments.
Comment at: clang/include/clang/Driver/Options.td:5166
+// VE feature flags
+let Flags = [TargetSpecific, CC1Option] in {
+def mvevpu : Flag<["-"], "mvevpu">, Group,
MaskRay wrote:
> Other feature
kaz7 updated this revision to Diff 550588.
kaz7 added a comment.
Update to follow suggestions. Thank you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157813/new/
https://reviews.llvm.org/D157813
Files:
clang/include/clang/Driver/Options.td
MaskRay added inline comments.
Comment at: clang/include/clang/Driver/Options.td:5169
+ HelpText<"Emit VPU instructions for VE">;
+def mno_vevpu : Flag<["-"], "mno-vevpu">, Group,
+ HelpText<"Do not emit VPU instructions for VE">;
In general, we just need docum
MaskRay added inline comments.
Comment at: clang/include/clang/Driver/Options.td:5166
+// VE feature flags
+let Flags = [TargetSpecific, CC1Option] in {
+def mvevpu : Flag<["-"], "mvevpu">, Group,
Other feature group options don't set CC1Option: we do not need t
kaz7 added reviewers: MaskRay, jdoerfert, awarzynski.
kaz7 added a comment.
I randamly added reviewrs who review code related to feature flags and features
group in clang. I appreciate if some of you guys have a time to check this
patch too. Thank you so much.
Repository:
rG LLVM Github Mo
kaz7 added a comment.
Thanks @efocht . I appreciate if someone working on clang can review this
patch too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157813/new/
https://reviews.llvm.org/D157813
___
efocht accepted this revision.
efocht added a comment.
This revision is now accepted and ready to land.
Looks good.
The default should be able to use intrinsics, hiding this only makes things
complicated and gets users confused.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
kaz7 created this revision.
kaz7 added a reviewer: efocht.
kaz7 added projects: clang, VE.
Herald added a project: All.
kaz7 requested review of this revision.
Herald added subscribers: cfe-commits, wangpc, MaskRay.
Change to enable VPU flag for VE by default in order to support vector
intrinsics
14 matches
Mail list logo
