[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

thakis added inline comments. Comment at: clang/test/Driver/x86-no-gather-no-scatter.cpp:3 +// RUN: %clang -c -mno-gather -### %s 2>&1 | FileCheck --check-prefix=NOGATHER %s +// RUN: %clang_cl -c /Qgather- -### %s 2>&1 | FileCheck --check-prefix=NOGATHER %s +// NOGATHER: "-targ

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

This revision was automatically updated to reflect the committed changes. Closed by commit rG993bdb047c90: [X86]Support options -mno-gather -mno-scatter (authored by XinWang10, committed by xin10.wang ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 updated this revision to Diff 551001. XinWang10 added a comment. - update fe test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680 Files: clang/include/clang/Driver/Options.td clang/lib/Drive

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

MaskRay added inline comments. Comment at: clang/test/Driver/x86-no-gather-no-scatter.cpp:4 +// RUN: | FileCheck --check-prefix=NOGATHER %s +// RUN: %clangxx -c -mno-gather -### %s 2>&1 \ +// RUN: | FileCheck --check-prefix=NOGATHER %s Each RUN line makes tests

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 marked an inline comment as done. XinWang10 added inline comments. Comment at: llvm/lib/Target/X86/X86.td:437 +: SubtargetFeature<"prefer-no-gather", "PreferGather", "false", + "Indicates if gather prefer to be disabled">; +def FeaturePreferNoS

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 updated this revision to Diff 549802. XinWang10 added a comment. - mov definition to tuning features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680 Files: clang/include/clang/Driver/Options.t

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 marked an inline comment as done. XinWang10 added inline comments. Comment at: llvm/lib/Target/X86/X86.td:437 +: SubtargetFeature<"prefer-no-gather", "PreferGather", "false", + "Indicates if gather prefer to be disabled">; +def FeaturePreferNoS

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86.td:437 +: SubtargetFeature<"prefer-no-gather", "PreferGather", "false", + "Indicates if gather prefer to be disabled">; +def FeaturePreferNoScatter XinWang10 wrote: > ska

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 marked 4 inline comments as done. XinWang10 added inline comments. Comment at: llvm/lib/Target/X86/X86.td:437 +: SubtargetFeature<"prefer-no-gather", "PreferGather", "false", + "Indicates if gather prefer to be disabled">; +def FeaturePreferNoS

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 updated this revision to Diff 549571. XinWang10 added a comment. - resolve comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680 Files: clang/include/clang/Driver/Options.td clang/lib/Dri

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

skan added inline comments. Comment at: llvm/lib/Target/X86/X86.td:437 +: SubtargetFeature<"prefer-no-gather", "PreferGather", "false", + "Indicates if gather prefer to be disabled">; +def FeaturePreferNoScatter Does "Prefer no gather in

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:903-906 +def mno_gather : Flag<["-"], "mno-gather">, Flags<[NoXarchOption]>, + HelpText<"Disable generation of gather instructions in auto-vectorization(x86 only)">; +def mno_scatter

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

pengfei added inline comments. Comment at: clang/include/clang/Driver/Options.td:903-906 +def mno_gather : Flag<["-"], "mno-gather">, Flags<[NoXarchOption]>, + HelpText<"Disable generation of gather instructions in auto-vectorization(x86 only)">; +def mno_scatter

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 updated this revision to Diff 549337. XinWang10 added a comment. - mv driver implement to x86 specific code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680 Files: clang/include/clang/Driver/Op

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

wangpc added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7527 + // -mno-gather, -mno-scatter support + if (Args.hasArg(options::OPT_mno_gather)) { +CmdArgs.push_back("-target-feature"); Put these in `clang/lib/Driver/ToolChains/Arch/X

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 updated this revision to Diff 549268. XinWang10 added a comment. - restore blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680 Files: clang/include/clang/Driver/Options.td clang/lib/D

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. XinWang10 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wangpc, MaskRay. Herald added projects: clang, LLVM. Gather instructions could lead to secur