Re: [PATCH] D15726: Remove setting of inlinehint and cold attributes based on profile data

2016-01-04 Thread Easwaran Raman via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL256793: Remove setting of inlinehint and cold attributes based on profile data (authored by eraman). Changed prior to commit: http://reviews.llvm.org/D15726?vs=43479&id=43937#toc Repository: rL LLVM

Re: [PATCH] D15726: Remove setting of inlinehint and cold attributes based on profile data

2015-12-30 Thread David Li via cfe-commits
davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D15726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D15726: Remove setting of inlinehint and cold attributes based on profile data

2015-12-22 Thread David Li via cfe-commits
davidxl added a comment. This looks like a straightforward cleanup (the test cases have been in a previous patch). http://reviews.llvm.org/D15726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D15726: Remove setting of inlinehint and cold attributes based on profile data

2015-12-22 Thread Easwaran Raman via cfe-commits
eraman created this revision. eraman added reviewers: bogner, davidxl. eraman added a subscriber: cfe-commits. NFC. These hints are only used for inlining and the inliner now uses the same criteria to identify hot and cold callees and set appropriate thresholds without relying on these hints. He