This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
yaxunl marked 2 inline comments as done.
Closed by commit rGf037b895b7e9: [CUDA][HIP] Reorganize options for
documentation (authored by yaxunl).
Herald added a project:
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: clang/include/clang/Driver/Options.td:155
+def offload_Group : OptionGroup<"">, Group,
+ DocName<"Common Offloading flags">;
+
MaskRay wrote:
> The existing `flag
MaskRay accepted this revision.
MaskRay added inline comments.
Comment at: clang/include/clang/Driver/Options.td:155
+def offload_Group : OptionGroup<"">, Group,
+ DocName<"Common Offloading flags">;
+
The existing `flags` uses are misnomer (`Fl
jhuber6 accepted this revision.
jhuber6 added a comment.
This revision is now accepted and ready to land.
I think this is good, there's been some confusion around which ones goes to
what.
Comment at: clang/include/clang/Driver/Options.td:1021
+def offload_host_device : Flag<["
yaxunl created this revision.
yaxunl added reviewers: tra, MaskRay, jhuber6.
Herald added subscribers: mattd, carlosgalvezp, Naghasan, Anastasia.
Herald added a reviewer: sscalpone.
Herald added a project: All.
yaxunl requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald add