[PATCH] D156886: [CUDA][HIP] Reorganize options for documentation

2023-08-04 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rGf037b895b7e9: [CUDA][HIP] Reorganize options for documentation (authored by yaxunl). Herald added a project:

[PATCH] D156886: [CUDA][HIP] Reorganize options for documentation

2023-08-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Options.td:155 +def offload_Group : OptionGroup<"">, Group, + DocName<"Common Offloading flags">; + MaskRay wrote: > The existing `flag

[PATCH] D156886: [CUDA][HIP] Reorganize options for documentation

2023-08-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:155 +def offload_Group : OptionGroup<"">, Group, + DocName<"Common Offloading flags">; + The existing `flags` uses are misnomer (`Fl

[PATCH] D156886: [CUDA][HIP] Reorganize options for documentation

2023-08-02 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. I think this is good, there's been some confusion around which ones goes to what. Comment at: clang/include/clang/Driver/Options.td:1021 +def offload_host_device : Flag<["

[PATCH] D156886: [CUDA][HIP] Reorganize options for documentation

2023-08-02 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, MaskRay, jhuber6. Herald added subscribers: mattd, carlosgalvezp, Naghasan, Anastasia. Herald added a reviewer: sscalpone. Herald added a project: All. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald add