felberj added a comment.
Thanks a lot for your notes! Unfortunately I noticed that while the test that I
created passed, my actual issue [0] still persists and I sent out the change
too early. It seems you are right and the symlink handling is in fact more
nuanced.
Enjoy your vacation! I will
sammccall added a comment.
I'm out on vacation the next two weeks, happy to look once back, otherwise
@kadircet would be the person to review this on the clangd side.
A couple of general notes:
- people use symlinks in different ways, to give files multiple names, the idea
that we can tell whi
felberj added a comment.
Sorry, I removed the reviewers again, because this might still need some work
e2e anymore. I will update this once I resolved that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156781/new/
https://reviews.llvm.org/D156781
felberj added a comment.
This addresses things like
- https://github.com/hedronvision/bazel-compile-commands-extractor/issues/136
- https://github.com/clangd/clangd/issues/124
Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1165
+auto Name = Node.getName();
+Output.
felberj created this revision.
Herald added subscribers: kadircet, arphaman, hiraditya.
Herald added a project: All.
felberj requested review of this revision.
Herald added subscribers: cfe-commits, llvm-commits, ilya-biryukov.
Herald added projects: clang, LLVM, clang-tools-extra.
This is done so
