This revision was automatically updated to reflect the committed changes.
Closed by commit rG23ef8bf9c0f3: [clangd][CodeComplete] Improve
FunctionCanBeCall (authored by zyounan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156605/new/
https://revi
zyounan updated this revision to Diff 557443.
zyounan added a comment.
Fix the CI
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156605/new/
https://reviews.llvm.org/D156605
Files:
clang-tools-extra/clangd/CodeComplete.cpp
clang-tools-extra/cla
zyounan updated this revision to Diff 557442.
zyounan added a comment.
Sorry, wrong patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156605/new/
https://reviews.llvm.org/D156605
Files:
clang-tools-extra/clangd/CodeComplete.cpp
clang-tools-e
zyounan updated this revision to Diff 557441.
zyounan added a comment.
Address nits; discard default template parameters
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156605/new/
https://reviews.llvm.org/D156605
Files:
clang/include/clang/Sema/S
zyounan marked 3 inline comments as done.
zyounan added a comment.
Thank you guys again for the long and meticulous review! :)
For a quick note, here are points I've excerpted from Nathan's reviews that
need improvements later:
1. Implement a heuristic that works for function template pointers
nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.
Thank you, the updates look good! Please go ahead and merge after addressing
the last minor nits.
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:594
+
zyounan added a comment.
Thank you Nathan for your constructive opinions! I've updated this patch again,
hopefully this becomes better.
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1387
- // When completing a non-static member function (and not via
- // dot/arrow member
zyounan updated this revision to Diff 556909.
zyounan marked 2 inline comments as done.
zyounan added a comment.
Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156605/new/
https://reviews.llvm.org/D156605
Files:
clang-tools-extra
zyounan added inline comments.
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3577
// containing all of the arguments up to the first deducible argument.
+ // Or, if this isn't a call, emit all the template arguments
+ // to disambiguate the (potential) overload
nridge requested changes to this revision.
nridge added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1297
+FunctionCanBeCall =
+MaybeDerived == MaybeBase || MaybeDerived->isDerivedFrom(MaybeBase);
+ }
nridge added a comment.
(I'm away on travels, will get back to this within the next week)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156605/new/
https://reviews.llvm.org/D156605
___
cfe-commits mailin
zyounan added a comment.
Gently ping~
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156605/new/
https://reviews.llvm.org/D156605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
zyounan updated this revision to Diff 551736.
zyounan added a comment.
Sorry, forgot to update tests :(
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156605/new/
https://reviews.llvm.org/D156605
Files:
clang-tools-extra/clangd/CodeComplete.cpp
zyounan updated this revision to Diff 551730.
zyounan added a comment.
Fix the bool expression.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156605/new/
https://reviews.llvm.org/D156605
Files:
clang-tools-extra/clangd/CodeComplete.cpp
clang-t
zyounan added a comment.
Thanks for Sam and Nathan's thorough review! I've updated, and please take
another look.
(Apologize for churning on weekends, but I don't have chunk time during the
week.)
Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:258
case Co
zyounan updated this revision to Diff 551723.
zyounan marked 14 inline comments as done.
zyounan added a comment.
Address many comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156605/new/
https://reviews.llvm.org/D156605
Files:
clang-tool
sammccall added a comment.
Thanks, this does look better.
I agree with Nathan's comments and will leave final stamp to him.
Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:144
+
+ // This variable would be discarded directly at the end of this function. We
+ /
nridge added a comment.
Thanks for the patch, these are nice improvements
Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:258
case CodeCompletionString::CK_RightParen:
+ if (DropFunctionArguments &&
+ ResultKind == CodeCompletionResult::RK_Decl
zyounan updated this revision to Diff 547569.
zyounan added a comment.
Trigger the build
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156605/new/
https://reviews.llvm.org/D156605
Files:
clang-tools-extra/clangd/CodeComplete.cpp
clang-tools-ex
19 matches
Mail list logo
