This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG23c39f9a9e14: [clang][Interp] Diagnose unknown parameter
values (authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D156509?v
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156509/new/
https://reviews.llvm.org/D156509
___
cfe-commits mailing lis
tbaeder marked an inline comment as done.
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/Interp.cpp:550-554
+ if (isa(D)) {
+S.FFDiag(E, diag::note_constexpr_function_param_value_unknown) << D;
+S.Note(D->getLocation(), diag::note_declared_at) << D->getS
tbaeder updated this revision to Diff 545193.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156509/new/
https://reviews.llvm.org/D156509
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/Interp.cpp
clang/lib/AST/Interp/Interp.h
clang/lib/AST/Interp/Opcodes.td
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/Interp.cpp:550-554
+ if (isa(D)) {
+S.FFDiag(E, diag::note_constexpr_function_param_value_unknown) << D;
+S.Note(D->getLocation(), diag::note_declared_at) << D->getSourceRange();
+return false;
+
tbaeder updated this revision to Diff 545028.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156509/new/
https://reviews.llvm.org/D156509
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/Interp.cpp
clang/lib/AST/Interp/Interp.h
clang/lib/AST/Interp/Opcodes.td
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews
