Re: [PATCH] D15647: [X86] Fix stack alignment for MCU target (Clang part)

This revision was automatically updated to reflect the committed changes. Closed by commit rL260376: [X86] Fix stack alignment for MCU target (Clang part), by Anton Nadolskiy. (authored by aturetsk). Changed prior to commit: http://reviews.llvm.org/D15647?vs=43788&id=47440#toc Repository: rL

Re: [PATCH] D15647: [X86] Fix stack alignment for MCU target (Clang part)

rjmccall added a comment. LGTM, thanks. http://reviews.llvm.org/D15647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15647: [X86] Fix stack alignment for MCU target (Clang part)

anadolskiy updated this revision to Diff 43788. anadolskiy added a comment. Thanks for review John. Addressed your comment. http://reviews.llvm.org/D15647 Files: tools/clang/include/clang/Basic/TargetInfo.h tools/clang/lib/AST/ASTContext.cpp tools/clang/lib/Basic/Targets.cpp tools/clang

Re: [PATCH] D15647: [X86] Fix stack alignment for MCU target (Clang part)

anadolskiy added a comment. ping http://reviews.llvm.org/D15647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15647: [X86] Fix stack alignment for MCU target (Clang part)

rjmccall added inline comments. Comment at: tools/clang/lib/AST/ASTContext.cpp:1902 @@ +1901,3 @@ + if (Target->getTriple().getArch() == llvm::Triple::xcore || + Target->getTriple().isOSIAMCU()) +return ABIAlign; // Never overalign on XCore and IAMCU. P

[PATCH] D15647: [X86] Fix stack alignment for MCU target (Clang part)

anadolskiy created this revision. anadolskiy added a reviewer: rjmccall. anadolskiy added a subscriber: cfe-commits. This patch fixes stack alignments for MCU (should be aligned to 4 bytes) LLVM part: http://reviews.llvm.org/D15646 http://reviews.llvm.org/D15647 Files: tools/clang/lib/AST/AST