[PATCH] D156461: [clang][ASTImporter] Merge implicit ctors with definition

balazske added a comment. After import we get a new AST that looks like this: |-CXXConstructorDecl 0x556e6a172d58 col:16 implicit used constexpr A 'void (A &&)' inline default trivial noexcept-unevaluated 0x556e6a172d58 | `-ParmVarDecl 0x556e6a172e78 col:16 'A &&' `-CXXConstructorDecl 0x

[PATCH] D156461: [clang][ASTImporter] Merge implicit ctors with definition

danix800 added a comment. In D156461#4583806 , @balazske wrote: > Normally what should happen is that a new move constructor is imported (with > a definition) and linked after the existing one (and the existing is not > modified). Does this violate the

[PATCH] D156461: [clang][ASTImporter] Merge implicit ctors with definition

danix800 added a comment. In D156461#4583806 , @balazske wrote: > It looks not good to remove an invalid node from the DeclContext that > otherwise remains in the AST. I checked the problem and found that the > existing move constructor (originally in t

[PATCH] D156461: [clang][ASTImporter] Merge implicit ctors with definition

balazske added a comment. It looks not good to remove an invalid node from the DeclContext that otherwise remains in the AST. I checked the problem and found that the existing move constructor (originally in the To AST which had no definition) gets a `getNumCtorInitializers` value of 1 but the

[PATCH] D156461: [clang][ASTImporter] Merge implicit ctors with definition

danix800 updated this revision to Diff 544854. danix800 edited the summary of this revision. Herald added a subscriber: pengfei. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156461/new/ https://reviews.llvm.org/D156461 Files: clang/lib/AST/ASTImp

[PATCH] D156461: [clang][ASTImporter] Merge implicit ctors with definition

danix800 created this revision. danix800 added a project: clang. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. danix800 requested review of this revision. Herald added a subscriber: cfe-commits. Implicit ctors