This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGaf91092c449d: [clang] Do not crash on use of a variadic
overloaded operator (authored by Fznamznon).
Repository:
rG LLVM Github Monorepo
CHANGES
Fznamznon added a comment.
Hmm, clang-format reports failure, but applying git-clang-format to the commit
doesn't give me anything. It seems the whole SemaOverload.cpp file has broken
formatting, maybe that is the reason for the failure.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAS
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156244/new/
https://reviews.llvm.org/D156244
Fznamznon marked an inline comment as done.
Fznamznon added inline comments.
Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64
+class E {};
+void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be
variadic}}
+void d() { E() + E(); }
---
Fznamznon updated this revision to Diff 546445.
Fznamznon added a comment.
Rebase, add more test cases, fix assertion on variadic functions inside of
`haveSameParameterTypes`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156244/new/
https://reviews
Fznamznon added inline comments.
Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64
+class E {};
+void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be
variadic}}
+void d() { E() + E(); }
cor3ntin wrote:
> aaron.ballman wrote:
cor3ntin added inline comments.
Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64
+class E {};
+void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be
variadic}}
+void d() { E() + E(); }
aaron.ballman wrote:
> cor3ntin wrote:
aaron.ballman added inline comments.
Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64
+class E {};
+void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be
variadic}}
+void d() { E() + E(); }
cor3ntin wrote:
> aaron.ballman wr
cor3ntin added inline comments.
Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64
+class E {};
+void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be
variadic}}
+void d() { E() + E(); }
aaron.ballman wrote:
> Fznamznon wrote:
aaron.ballman added subscribers: cor3ntin, hubert.reinterpretcast, rsmith.
aaron.ballman added inline comments.
Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64
+class E {};
+void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be
variadic}}
+
Fznamznon added inline comments.
Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64
+class E {};
+void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be
variadic}}
+void d() { E() + E(); }
aaron.ballman wrote:
> I think it migh
aaron.ballman added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:14001
+
+if (FnDecl->isInvalidDecl())
+ return ExprError();
shafik wrote:
> aaron.ballman wrote:
> > Fznamznon wrote:
> > > Fznamznon wrote:
> > > > shafik wrote:
>
shafik added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:14001
+
+if (FnDecl->isInvalidDecl())
+ return ExprError();
aaron.ballman wrote:
> Fznamznon wrote:
> > Fznamznon wrote:
> > > shafik wrote:
> > > > Fznamznon wrote:
> > >
aaron.ballman added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:14001
+
+if (FnDecl->isInvalidDecl())
+ return ExprError();
Fznamznon wrote:
> Fznamznon wrote:
> > shafik wrote:
> > > Fznamznon wrote:
> > > > shafik wrote:
> > >
Fznamznon added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:14001
+
+if (FnDecl->isInvalidDecl())
+ return ExprError();
Fznamznon wrote:
> shafik wrote:
> > Fznamznon wrote:
> > > shafik wrote:
> > > > shafik wrote:
> > > > > It
Fznamznon added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:14001
+
+if (FnDecl->isInvalidDecl())
+ return ExprError();
shafik wrote:
> Fznamznon wrote:
> > shafik wrote:
> > > shafik wrote:
> > > > It feels a bit weird that we a
shafik added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:14001
+
+if (FnDecl->isInvalidDecl())
+ return ExprError();
Fznamznon wrote:
> shafik wrote:
> > shafik wrote:
> > > It feels a bit weird that we are succeeding in finding
shafik added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:14001
+
+if (FnDecl->isInvalidDecl())
+ return ExprError();
shafik wrote:
> It feels a bit weird that we are succeeding in finding the best viable
> function and what we f
Fznamznon added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:14001
+
+if (FnDecl->isInvalidDecl())
+ return ExprError();
shafik wrote:
> It feels a bit weird that we are succeeding in finding the best viable
> function and what w
shafik added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:14001
+
+if (FnDecl->isInvalidDecl())
+ return ExprError();
It feels a bit weird that we are succeeding in finding the best viable function
and what we find is invalid.
Fznamznon created this revision.
Herald added a project: All.
Fznamznon requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Just exit instead.
Fixes https://github.com/llvm/llvm-project/issues/42535
Repository:
rG LLVM Github Monorepo
http
21 matches
Mail list logo
