imkiva added a comment.
Looks like I am reading a very old version of the spec haha. Anyway, thank you
all for giving me the newest information and useful links! Thanks!!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156214/new/
https://reviews.ll
craig.topper added a comment.
I have deleted the two TODOs in r02c11c5aed59624046125cf512c12f70d2fa358d
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156214/new/
https://reviews.llvm.org/D156214
___
cfe-
craig.topper added inline comments.
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:948
- // TODO: The 'q' extension requires rv64.
- // TODO: It is illegal to specify 'e' extensions with 'f' and 'd'.
craig.topper wrote:
> asb wrote:
> > imkiva wrote:
> > > wan
craig.topper added inline comments.
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:948
- // TODO: The 'q' extension requires rv64.
- // TODO: It is illegal to specify 'e' extensions with 'f' and 'd'.
asb wrote:
> imkiva wrote:
> > wangpc wrote:
> > > I think t
craig.topper added inline comments.
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:948
// Additional dependency checks.
- // TODO: The 'q' extension requires rv64.
- // TODO: It is illegal to specify 'e' extensions with 'f' and 'd'.
+ // The 'q' extension requires rv64.
+ i
craig.topper added inline comments.
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:948
// Additional dependency checks.
- // TODO: The 'q' extension requires rv64.
- // TODO: It is illegal to specify 'e' extensions with 'f' and 'd'.
+ // The 'q' extension requires rv64.
+ i
asb added inline comments.
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:948
- // TODO: The 'q' extension requires rv64.
- // TODO: It is illegal to specify 'e' extensions with 'f' and 'd'.
imkiva wrote:
> wangpc wrote:
> > I think the comment is outdated her
imkiva added a comment.
address review comments
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:948
- // TODO: The 'q' extension requires rv64.
- // TODO: It is illegal to specify 'e' extensions with 'f' and 'd'.
wangpc wrote:
> I think the comment is outdate
wangpc added inline comments.
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:948
- // TODO: The 'q' extension requires rv64.
- // TODO: It is illegal to specify 'e' extensions with 'f' and 'd'.
I think the comment is outdated here. `E` can be combined with all
imkiva updated this revision to Diff 543890.
imkiva added a comment.
Removed some tests that used `e` together with `f` or `d`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156214/new/
https://reviews.llvm.org/D156214
Files:
clang/test/Driver/ri
imkiva created this revision.
imkiva added a reviewer: craig.topper.
imkiva added a project: LLVM.
Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck,
luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei,
PkmX, the_o, brucehoult, MartinMosbeck, rogfer0
11 matches
Mail list logo