This revision was automatically updated to reflect the committed changes.
Closed by commit rG778a5e9bc633: [include-cleaner] Introduce support for
always_keep pragma (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156122/new/
h
VitaNuo accepted this revision.
VitaNuo added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156122/new/
https://reviews.llvm.org/D156122
__
kadircet updated this revision to Diff 546001.
kadircet marked an inline comment as done.
kadircet added a comment.
- Rebase
- Properly check for null-ness of FileEntry.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156122/new/
https://reviews.llvm
kadircet marked an inline comment as done.
kadircet added inline comments.
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:63
+ bool shouldKeep(unsigned HashLineNumber) const;
+ bool shouldKeep(const FileEntry *FE) const;
VitaNuo added inline comments.
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:63
+ bool shouldKeep(unsigned HashLineNumber) const;
+ bool shouldKeep(const FileEntry *FE) const;
Why wouldn't you actually inline the implem
kadircet added a comment.
FWIW, details of pragma are explained in
https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md#iwyu-pragma-always_keep
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156122/new/
https
kadircet created this revision.
kadircet added a reviewer: VitaNuo.
Herald added subscribers: PiotrZSL, carlosgalvezp, arphaman.
Herald added a reviewer: njames93.
Herald added a project: All.
kadircet requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subs
