[PATCH] D156063: [Clang] Reject programs declaring namespace std to be inline

rZhBoYao added a comment. Thanks for all the suggestions and review comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156063/new/ https://reviews.llvm.org/D156063 ___ cfe-commits mailing list cfe-c

[PATCH] D156063: [Clang] Reject programs declaring namespace std to be inline

This revision was automatically updated to reflect the committed changes. Closed by commit rGbed75faf7d76: [Clang] Reject programs declaring namespace std to be inline (authored by rZhBoYao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156063/new/

[PATCH] D156063: [Clang] Reject programs declaring namespace std to be inline

MitalAshok accepted this revision. MitalAshok added a comment. This revision is now accepted and ready to land. Looks good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156063/new/ https://reviews.llvm.org/D156063 ___ cfe-commits mailing lis

[PATCH] D156063: [Clang] Reject programs declaring namespace std to be inline

rZhBoYao updated this revision to Diff 543514. rZhBoYao marked an inline comment as done. rZhBoYao added a comment. Addressed comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156063/new/ https://reviews.llvm.org/D156063 Files: clang/docs/ReleaseNotes.rst clang/include/clang/B

[PATCH] D156063: [Clang] Reject programs declaring namespace std to be inline

MitalAshok requested changes to this revision. MitalAshok added a comment. This revision now requires changes to proceed. This does currently break `namespace foo { inline namespace std {} }`, `namespace foo::inline std {}`, etc. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1136

[PATCH] D156063: [Clang] Reject programs declaring namespace std to be inline

cor3ntin added a comment. Can you add a test for `foo::std` ? I suspects it warns, which is incorrect ? Can you add additional tests for `inline std::foo` ? (which should warn) Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156063/new/ htt

[PATCH] D156063: [Clang] Reject programs declaring namespace std to be inline

rZhBoYao added a comment. https://eel.is/c++draft/namespace.std#7 is in the library clause. Couldn't find a better place to put the test other than clang/test/CXX/dcl.dcl/basic.namespace/namespace.def/p7.cpp which is for https://eel.is/c++draft/namespace.def.general#4.sentence-2. Repository:

[PATCH] D156063: [Clang] Reject programs declaring namespace std to be inline

rZhBoYao created this revision. rZhBoYao added reviewers: philnik, clang-language-wg. Herald added a project: All. rZhBoYao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156