This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG92ac46e703cf: [clang][Interp] Handle CXXParenListInitExprs
(authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D156047?vs=544
tbaeder added a comment.
> Also, can you try to add the new interpreter to
> test/SemaCXX/paren-list-agg-init.cpp ?
Hmm no, looks like there's a problem with rvalue references.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156047/new/
https://reviews.llvm.org/D156047
cor3ntin accepted this revision.
cor3ntin added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
But please look at the bot failures, i suppose you need to rebase before
merging.
Also, can you try to add the new interpreter to
`test/SemaCXX/paren-list-agg-init.cpp` ?
C
tbaeder updated this revision to Diff 544692.
tbaeder marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156047/new/
https://reviews.llvm.org/D156047
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/ByteCodeExprGen.h
clang/test/AST/I
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:661
assert(E->getNumInits() == 1);
return DiscardResult ? this->discard(E->inits()[0])
: this->visit(E->inits()[0]);
cor3ntin wrote:
> how coul
cor3ntin added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:661
assert(E->getNumInits() == 1);
return DiscardResult ? this->discard(E->inits()[0])
: this->visit(E->inits()[0]);
how could DiscardResult e
tbaeder updated this revision to Diff 543522.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156047/new/
https://reviews.llvm.org/D156047
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/ByteCodeExprGen.h
clang/test/AST/Interp/records.cpp
clang/test/SemaCXX/sou
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews
