[PATCH] D156044: [clangd] Exclude builtin headers from system include extraction

2023-07-25 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0478ef2d366c: [clangd] Exclude builtin headers from system include extraction (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156044/n

[PATCH] D156044: [clangd] Exclude builtin headers from system include extraction

2023-07-24 Thread Paul Smith via Phabricator via cfe-commits
madscientist added a comment. (just a note that another way to do this check is to look for some common intrinsic file in each directory generated by the compiler driver, and remove any directory containing those files. But, if the `-print-file-name=include` trick works reliably that's good to

[PATCH] D156044: [clangd] Exclude builtin headers from system include extraction

2023-07-24 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156044/new/ https://reviews.llvm.org/D156044 __

[PATCH] D156044: [clangd] Exclude builtin headers from system include extraction

2023-07-23 Thread Paul Smith via Phabricator via cfe-commits
madscientist added a comment. I built latest main with this patch applied and it does fix the issues in my environment. My headers that include xmmintrin.h etc. don't throw errors in clangd. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D156044: [clangd] Exclude builtin headers from system include extraction

2023-07-23 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 543291. sammccall added a comment. fix incomplete cleanup of dead option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156044/new/ https://reviews.llvm.org/D156044 Files: clang-tools-extra/clangd/SystemInc

[PATCH] D156044: [clangd] Exclude builtin headers from system include extraction

2023-07-22 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 543253. sammccall added a comment. remove (broken) support for -nobuiltininc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156044/new/ https://reviews.llvm.org/D156044 Files: clang-tools-extra/clangd/Syste

[PATCH] D156044: [clangd] Exclude builtin headers from system include extraction

2023-07-22 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: kadircet, madscientist. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra