[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

tbaeder closed this revision. tbaeder added a comment. This has been pushed already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156042/new/ https://reviews.llvm.org/D156042 ___ cfe-commits mailing lis

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

vitalybuka added a comment. Reverted with D155568 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156042/new/ https://reviews.llvm.org/D156042 ___ cfe-commits mailing lis

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd425720aed48: [clang][Interp] Implement __builtin_strlen (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D156042?vs=54341

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM, modulo suggestion Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:63-69 + if (SizeTWidth == 64) +S.Stk.push>(Integral<64, false>::from(Val)); + else if (Si

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

tbaeder updated this revision to Diff 543414. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156042/new/ https://reviews.llvm.org/D156042 Files: clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index: clang/t

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:114 + + // TODO: Push platform-dependent size_t. + S.Stk.push>(Integral<64, false>::from(Len)); cor3ntin wrote: > Why not do that in this

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

tbaeder updated this revision to Diff 543317. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156042/new/ https://reviews.llvm.org/D156042 Files: clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index: clang/test/AST/Interp/builtin-functions.cpp =

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:101-112 + for (;;) { +const Pointer &ElemPtr = StrPtr.atIndex(I); + +if (!CheckRange(S, OpPC, ElemPtr, AK_Read)) + return false; + +uint8_t Val = ElemPtr.deref();

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews