[PATCH] D155776: [NFC] Add checks for self-assignment.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ad89131e0de: [NFC] Add checks for self-assignment. (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir marked an inline comment as done. schittir added a comment. Thank you for the review, @aaron.ballman and @tahonermann Investigating the build failure... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776

[PATCH] D155776: [NFC] Add checks for self-assignment.

tahonermann accepted this revision. tahonermann added a comment. Thank you for following up, Sindhu! Looks good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 ___ cfe-commits mailing list cfe-commi

[PATCH] D155776: [NFC] Add checks for self-assignment.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir added a comment. @jplehr @michaelplatings @MitalAshok @tahonermann - sorry this one slipped through the cracks. I fixed the errors now. Thank you for your review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 __

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir updated this revision to Diff 552243. schittir added a comment. Fix errors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 Files: clang/lib/AST/APValue.cpp clang/lib/CodeGen/CGDebugInfo.h clang/lib/Interpreter/Value.cpp Index

[PATCH] D155776: [NFC] Add checks for self-assignment.

michaelplatings added a comment. I reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D155776: [NFC] Add checks for self-assignment.

MitalAshok added a comment. This doesn't compile, could you fix this or revert 8ac137acefc01caf636db5f95eb0977c97def1ba ? Comment at: clang/lib/AST/APValue.cpp:393 APValue &APValue::operator=(APValue &&RHS

[PATCH] D155776: [NFC] Add checks for self-assignment.

jplehr added a comment. Hi, it seems that this broke the AMDGPU OpenMP buildbot https://lab.llvm.org/buildbot/#/builders/193/builds/35271 Happy to help if you need more info etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://re

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir added a comment. @tahonermann Thank you for considering this thoroughly. This patch is now landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 ___

[PATCH] D155776: [NFC] Add checks for self-assignment.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ac137acefc0: [NFC] Add checks for self-assignment. (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D155776: [NFC] Add checks for self-assignment.

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. On second thought, and after having read https://stackoverflow.com/a/9322542/11634221, I think this change is fine. There are legitimate scenarios for which self move assignment shou

[PATCH] D155776: [NFC] Add checks for self-assignment.

tahonermann added a comment. Hmm, it seems exceptionally unlikely for a move assignment operator to be invoked on an object with itself as the source argument. That would require an explicit use of `std::move()` as in: Value x = ...; x = std::move(x); Rather than protecting against that an

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir updated this revision to Diff 542333. schittir added a comment. Please consider these changes for review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 Files: clang/lib/AST/APValue.cpp clang/lib/CodeGen/CGDebugInfo.h clang/lib

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir created this revision. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D155776 Files: clang/include/clang/Sema/ObjCMethodList.