This revision was automatically updated to reflect the committed changes.
Closed by commit rL255814: [PS4] Fix the unit test to be compatible with clang
driver. NFC (authored by sgundapa).
Changed prior to commit:
http://reviews.llvm.org/D15577?vs=43038&id=43049#toc
Repository:
rL LLVM
http
probinson accepted this revision.
probinson added a reviewer: probinson.
probinson added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D15577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
sgundapa updated this revision to Diff 43038.
http://reviews.llvm.org/D15577
Files:
lib/Driver/Tools.cpp
test/Driver/sanitizer-ld.c
Index: test/Driver/sanitizer-ld.c
===
--- test/Driver/sanitizer-ld.c
+++ test/Driver/sanitizer-l
sgundapa added a comment.
GetProgramPath will take care of the extension.
I will change the line to "{{.*}}ld{{(.gold)?(.exe)?}}" as per your suggestion
and push a new patch
http://reviews.llvm.org/D15577
___
cfe-commits mailing list
cfe-commits@li
probinson added a subscriber: probinson.
probinson added a comment.
So, mainly you want calls to GetProgramPath not to provide the .exe extension,
even on Windows?
Comment at: test/Driver/sanitizer-ld.c:382
@@ -381,3 +381,3 @@
// RUN: | FileCheck --check-prefix=CHECK-UBSAN-P
sgundapa created this revision.
sgundapa added reviewers: eugenis, filcab.
sgundapa added a subscriber: cfe-commits.
".exe" extension is inherently checked by llvm::fs::can_execute()
This patch fixes the linker extension in clang driver and updates the
unit test to accommodate the the check string
