[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb93d2d37e709: [clang][Interp] Handle SourceLocExprs (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder added a comment. I do in https://reviews.llvm.org/D156045, but that depends on other commits (not sure which exactly right now though). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 ___ cf

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

cor3ntin added a comment. So you can enable some of the sema source location tests? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder updated this revision to Diff 551854. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Program.cpp clang/test/AST/Interp/b

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder added a comment. All the dependencies have been pushed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

aaron.ballman added a comment. In D155627#4598032 , @tbaeder wrote: > In D155627#4596321 , @aaron.ballman > wrote: > >> In D155627#4595089 , @tbaeder >> wrote: >> >>> Ha

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder added a comment. In D155627#4596321 , @aaron.ballman wrote: > In D155627#4595089 , @tbaeder wrote: > >> Having https://reviews.llvm.org/D144457 and https://reviews.llvm.org/D144457 >> approved would make

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

aaron.ballman added a comment. In D155627#4595089 , @tbaeder wrote: > Having https://reviews.llvm.org/D144457 and https://reviews.llvm.org/D144457 > approved would make rebasing easier :) I can look into https://reviews.llvm.org/D144457, but then having

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder added a comment. Having https://reviews.llvm.org/D144457 and https://reviews.llvm.org/D144457 approved would make rebasing easier :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 ___ cfe-c

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

cor3ntin added a comment. @tbaeder Maybe you could land the dependencies of this patch so that we can progress it. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 ___ cfe-commits mailing lis

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

cor3ntin added a comment. FYI i think this is fine but I'm waiting for progress on the PRs that would allow us to enable more tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 ___ cfe-commits m

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder added a comment. @cor3ntin Ok, I need... - https://reviews.llvm.org/D155707 - https://reviews.llvm.org/D156027 - https://reviews.llvm.org/D156042 to enable the existing tests with at least one of the RUN lines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder updated this revision to Diff 543249. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Program.cpp clang/test/AST/Interp/b

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder updated this revision to Diff 543212. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Program.cpp clang/test/AST/Interp/b

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder updated this revision to Diff 542420. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Program.cpp clang/test/AST/Interp/b

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder added inline comments. Comment at: clang/test/AST/Interp/builtin-functions.cpp:153 + static_assert(__builtin_LINE() == 152, ""); +} cor3ntin wrote: > tbaeder wrote: > > tbaeder wrote: > > > cor3ntin wrote: > > > > what is missing to enable the existing s

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

cor3ntin added inline comments. Comment at: clang/test/AST/Interp/builtin-functions.cpp:153 + static_assert(__builtin_LINE() == 152, ""); +} tbaeder wrote: > tbaeder wrote: > > cor3ntin wrote: > > > what is missing to enable the existing source location tests wi

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder added inline comments. Comment at: clang/test/AST/Interp/builtin-functions.cpp:153 + static_assert(__builtin_LINE() == 152, ""); +} tbaeder wrote: > cor3ntin wrote: > > what is missing to enable the existing source location tests with the new > > intter

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder added a comment. In D155627#4513433 , @cor3ntin wrote: > Note that you are probably need something like `SourceLocExprScopeGuard` to > make source_location actually work, , it might be worth doing in this patch. > The idea is to remember the loca

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

cor3ntin added inline comments. Comment at: clang/test/AST/Interp/builtin-functions.cpp:153 + static_assert(__builtin_LINE() == 152, ""); +} what is missing to enable the existing source location tests with the new intterpreter? Repository: rG LLVM Github M

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

cor3ntin added a comment. Note that you are probably need something like `SourceLocExprScopeGuard` to make source_location actually work, , it might be worth doing in this patch. The idea is to remember the location of a call when evaluating default arguments / default member initializers Repo

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a bit awkward, since we get an `APValue` from