[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

yaxunl added a comment. In D155539#4528137 , @yaxunl wrote: > In D155539#4528094 , @probinson > wrote: > >> In D155539#4524543 , @yaxunl wrote: >> >>> In D155539#4524189

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

yaxunl added a comment. In D155539#4528094 , @probinson wrote: > In D155539#4524543 , @yaxunl wrote: > >> In D155539#4524189 , @probinson >> wrote: >> >>> This change to

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

probinson added a comment. In D155539#4524543 , @yaxunl wrote: > In D155539#4524189 , @probinson > wrote: > >> This change to lang-std.cpp causes it not to verify _which_ language >> standard is the default. It

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

yaxunl added a comment. In D155539#4524189 , @probinson wrote: > This change to lang-std.cpp causes it not to verify _which_ language standard > is the default. It only verifies that cuda and hip don't _change_ it. > If you run FileCheck on one of those

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

probinson added a comment. This change to lang-std.cpp causes it not to verify _which_ language standard is the default. It only verifies that cuda and hip don't _change_ it. If you run FileCheck on one of those output files, it would preserve that property. Repository: rG LLVM Github Monore

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

yaxunl added a comment. In D155539#4517882 , @sylvestre.ledru wrote: > I reverted the patch for causing > https://github.com/llvm/llvm-project/issues/63974 > https://github.com/llvm/llvm-project/commit/443f490b6aac4af28500f4b09b68a13260f4fba9 Thanks. I

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

sylvestre.ledru added a comment. I reverted the patch for causing https://github.com/llvm/llvm-project/issues/63974 https://github.com/llvm/llvm-project/commit/443f490b6aac4af28500f4b09b68a13260f4fba9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

dyung added a comment. Hi @yaxunl, your change appears to have broken the LLDB build. Can you take a look and revert if you time to investigate? https://lab.llvm.org/buildbot/#/builders/243/builds/9581 FAILED: tools/lldb/source/Plugins/TypeSystem/Clang/CMakeFiles/lldbPluginTypeSystemClang.di

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d1d07152bd2: [CUDA][HIP] Use the same default language std as C++ (authored by yaxunl). Herald added a project: clang. Changed prior to commit: h

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

yaxunl updated this revision to Diff 541836. yaxunl added a comment. update release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155539/new/ https://reviews.llvm.org/D155539 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/LangStandards.def clang/lib/Basic/LangS

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

tra accepted this revision. tra added a comment. We should probably update documentation that C++ standard version for CUDA/HIP compilation now matches C++ default instead of previously used c++14. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155539/new/ https://reviews.llvm.org/D1555

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

scchan accepted this revision. scchan added a comment. This revision is now accepted and ready to land. LGTM thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155539/new/ https://reviews.llvm.org/D155539 ___ cfe-commits mailing list cfe-c

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. yaxunl requested review of this revision. Currently CUDA/HIP defines their own language standards in LanguageStandards.def but they are redundant. They are the