zyounan updated this revision to Diff 543280.
zyounan added a comment.
Format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155370/new/
https://reviews.llvm.org/D155370
Files:
clang-tools-extra/clangd/CodeComplete.cpp
clang-tools-extra/clangd/
zyounan updated this revision to Diff 543277.
zyounan added a comment.
Don't change the CCR. Handle these in CreateCodeCompletionString. Emit template
arguments if possible.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155370/new/
https://reviews
sammccall added a comment.
I'm not sure switching to RK_Pattern is ideal, but I think there are a couple
of (easy?) alternatives that achieve the same.
> Regard to the heuristic itself, it's currently a bit inconvenient that I have
> to switch headers and sources back and forth and do copy-past
zyounan created this revision.
zyounan added reviewers: nridge, tom-anders, sammccall.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
zyounan added a comment.
zyounan updated this revision to Diff 540687.
zyounan published this revision for review.
Herald added projects:
