Re: [PATCH] D15516: [libcxx] Enable noexcept for GCC 4.6 and greater

2015-12-15 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Other than the `_NOEXCEPT_OR_FALSE` thing, this LGTM. http://reviews.llvm.org/D15516 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D15516: [libcxx] Enable noexcept for GCC 4.6 and greater

2015-12-15 Thread Eric Fiselier via cfe-commits
EricWF added a comment. In http://reviews.llvm.org/D15516#311280, @mclow.lists wrote: > do we even use `_NOEXCEPT_OR_FALSE` any more? Doesn't look like it. http://reviews.llvm.org/D15516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: [PATCH] D15516: [libcxx] Enable noexcept for GCC 4.6 and greater

2015-12-15 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. do we even use `_NOEXCEPT_OR_FALSE` any more? http://reviews.llvm.org/D15516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15516: [libcxx] Enable noexcept for GCC 4.6 and greater

2015-12-14 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 42813. EricWF added a comment. Woops. I forgot to turn off `noexcept` support in C++03 mode for GCC. http://reviews.llvm.org/D15516 Files: include/__config Index: include/__config === --- inc

[PATCH] D15516: [libcxx] Enable noexcept for GCC 4.6 and greater

2015-12-14 Thread Eric Fiselier via cfe-commits
EricWF created this revision. EricWF added reviewers: mclow.lists, danalbert, jroelofs. EricWF added a subscriber: cfe-commits. This patch allows GCC 4.6 and above to use `noexcept` as opposed to `throw()`. Is it an ABI safe change to suddenly switch on `noexcept`? I imagine it must be because