[PATCH] D155111: [clangd] Fix build failures observed on build bots for missing libs

2023-07-17 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir added a comment. In D155111#4495131 , @mstorsjo wrote: > To clarify the issue - the kind of builds that seems to be broken is builds > with `BUILD_SHARED_LIBS=ON`. The reason is that these libraries are needed is > because the `clangd` target inc

[PATCH] D155111: [clangd] Fix build failures observed on build bots for missing libs

2023-07-12 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. To clarify the issue - the kind of builds that seems to be broken is builds with `BUILD_SHARED_LIBS=ON`. The reason is that these libraries are needed is because the `clangd` target includes `$`, so all the dependencies of `clangDaemonTweaks` would need to be included

[PATCH] D155111: [clangd] Fix build failures observed on build bots for missing libs

2023-07-12 Thread Ahsan Saghir via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG915659bfa1e9: [clangd] Fix build failures observed on build bots for missing libs (authored by saghir). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D155111: [clangd] Fix build failures observed on build bots for missing libs

2023-07-12 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. Lets get this committed to unblock the bots and if it is not the correct/desired fix, the author can subsequently provide the more appropriate fix. Repository: rG LLVM Github Monorepo

[PATCH] D155111: [clangd] Fix build failures observed on build bots for missing libs

2023-07-12 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir added a comment. @mstorsjo @ivanmurashko Can you please take a look at this? This is blocking our builds on the PowerPC buildbots. Thanks a lot for your time! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155111/new/ https://reviews.llvm.or

[PATCH] D155111: [clangd] Fix build failures observed on build bots for missing libs

2023-07-12 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir added a comment. This is to fix failures in the build bot: https://lab.llvm.org/buildbot/#/builders/57/builds/28356 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155111/new/ https://reviews.llvm.org/D155111

[PATCH] D155111: [clangd] Fix build failures observed on build bots for missing libs

2023-07-12 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. saghir requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This was broken by 56ac9d46a7c1468d587ccec02a