[PATCH] D154881: [HIP] Ignore host linker flags for device-only

2023-07-17 Thread Siu Chi Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcbc4bbb85c72: [HIP] Ignore host linker flags for device-only (authored by scchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154881/new/ https://reviews

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

2023-07-17 Thread Siu Chi Chan via Phabricator via cfe-commits
scchan updated this revision to Diff 541060. scchan added a comment. minor formatting fixes, rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154881/new/ https://reviews.llvm.org/D154881 Files: clang/lib/Driver/Driver.cpp clang/test/Drive

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

2023-07-14 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154881/new/ https://reviews.llvm.org/D154881 __

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

2023-07-14 Thread Siu Chi Chan via Phabricator via cfe-commits
scchan updated this revision to Diff 540481. scchan added a comment. added extra checks for not host, rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154881/new/ https://reviews.llvm.org/D154881 Files: clang/lib/Driver/Driver.cpp clang/t

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

2023-07-13 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: clang/test/Driver/hip-phases.hip:275 // RELOC-DAG: [[P5:[0-9]+]]: offload, "device-[[T]] (amdgcn-amd-amdhsa:[[ARCH]])" {[[P4]]}, object // need to check RELOC-NOT: host Comment at: clang/test/Drive

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

2023-07-11 Thread Siu Chi Chan via Phabricator via cfe-commits
scchan updated this revision to Diff 539173. scchan added a comment. addressed comments from yaxunl, rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154881/new/ https://reviews.llvm.org/D154881 Files: clang/lib/Driver/Driver.cpp clang/te

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

2023-07-10 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4150 + (C.getInputArgs().hasArg(options::OPT_emit_llvm))) && +!C.getInputArgs().hasArg(options::OPT_offload_device_only)) LinkerInputs.push_back(Current); The

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

2023-07-10 Thread Siu Chi Chan via Phabricator via cfe-commits
scchan created this revision. scchan added a reviewer: yaxunl. Herald added a project: All. scchan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. When compiling in device only mode (e.g. --offload-device-only), the host linker phas