This revision was automatically updated to reflect the committed changes.
Closed by commit rGcbc4bbb85c72: [HIP] Ignore host linker flags for device-only
(authored by scchan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154881/new/
https://reviews
scchan updated this revision to Diff 541060.
scchan added a comment.
minor formatting fixes, rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154881/new/
https://reviews.llvm.org/D154881
Files:
clang/lib/Driver/Driver.cpp
clang/test/Drive
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154881/new/
https://reviews.llvm.org/D154881
__
scchan updated this revision to Diff 540481.
scchan added a comment.
added extra checks for not host, rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154881/new/
https://reviews.llvm.org/D154881
Files:
clang/lib/Driver/Driver.cpp
clang/t
yaxunl added inline comments.
Comment at: clang/test/Driver/hip-phases.hip:275
// RELOC-DAG: [[P5:[0-9]+]]: offload, "device-[[T]]
(amdgcn-amd-amdhsa:[[ARCH]])" {[[P4]]}, object
//
need to check RELOC-NOT: host
Comment at: clang/test/Drive
scchan updated this revision to Diff 539173.
scchan added a comment.
addressed comments from yaxunl, rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154881/new/
https://reviews.llvm.org/D154881
Files:
clang/lib/Driver/Driver.cpp
clang/te
yaxunl added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:4150
+ (C.getInputArgs().hasArg(options::OPT_emit_llvm))) &&
+!C.getInputArgs().hasArg(options::OPT_offload_device_only))
LinkerInputs.push_back(Current);
The
scchan created this revision.
scchan added a reviewer: yaxunl.
Herald added a project: All.
scchan requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
When compiling in device only mode (e.g. --offload-device-only), the
host linker phas