Re: [PATCH] D15470: Preserve source location in namespaced base ctor initializers

2015-12-12 Thread Shahms King via cfe-commits
shahms updated this revision to Diff 42608. shahms added a comment. Address comments and add CHECK for TypeRef as well http://reviews.llvm.org/D15470 Files: lib/Sema/SemaDeclCXX.cpp test/Index/namespaced-base-ctor-init.cpp Index: test/Index/namespaced-base-ctor-init.cpp ===

Re: [PATCH] D15470: Preserve source location in namespaced base ctor initializers

2015-12-12 Thread Shahms King via cfe-commits
shahms marked 2 inline comments as done. shahms added a comment. Thanks for taking a look at this so quickly. I've updated the test to make sure the TypeRef is correct as well, in light of the changes here. http://reviews.llvm.org/D15470 ___ cfe-c

Re: [PATCH] D15470: Preserve source location in namespaced base ctor initializers

2015-12-11 Thread Richard Smith via cfe-commits
rsmith closed this revision. rsmith added a comment. Committed as r255420. Thanks for the patch! http://reviews.llvm.org/D15470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15470: Preserve source location in namespaced base ctor initializers

2015-12-11 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D15470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D15470: Preserve source location in namespaced base ctor initializers

2015-12-11 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. Comment at: lib/Sema/SemaDeclCXX.cpp:2987 @@ +2986,3 @@ +TInfo = Context.CreateTypeSourceInfo(BaseType); +ElaboratedTypeLoc TL = TInfo->getTypeLoc().castAs(); +TL.setElaboratedKeywordLoc(IdLoc); You also n

[PATCH] D15470: Preserve source location in namespaced base ctor initializers

2015-12-11 Thread Shahms King via cfe-commits
shahms created this revision. shahms added a subscriber: cfe-commits. Resolved a FIXME to preserve source location in qualified base initializers. This patch preserves location information for constructs such as: namespace ns1 { struct Base {}; struct Derived : Base { Derived() : ns1::Base