[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa0130fc51cbc: [clang] Correct calculation of MemberExpr's dependence (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon updated this revision to Diff 538531. Fznamznon added a comment. Rebase, add tests for dependent NameInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154689/new/ https://reviews.llvm.org/D154689 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

shafik accepted this revision. shafik added a comment. LGTM, thank you for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154689/new/ https://reviews.llvm.org/D154689 ___ cfe-commits mailin

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

cor3ntin added a comment. In D154689#4480282 , @Fznamznon wrote: > In D154689#4480249 , @cor3ntin > wrote: > >> I think this makes sense and it implements richard's suggestion. >> However, it's missing a release

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon added a comment. In D154689#4480249 , @cor3ntin wrote: > I think this makes sense and it implements richard's suggestion. > However, it's missing a release note, can you add that before landing? > Thanks Thank you for the review. I think I ad

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. I think this makes sense and it implements richard's suggestion. However, it's missing a release note, can you add that before landing? Thanks Repository: rG LLVM Github Monorepo CHAN

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

cor3ntin added inline comments. Comment at: clang/lib/AST/Expr.cpp:1760 + // FIXME: remove remaining dependence computation to computeDependence(). + auto Deps = E->getDependence(); Fznamznon wrote: > cor3ntin wrote: > > Maybe we should do that now, by passin

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon added inline comments. Comment at: clang/lib/AST/Expr.cpp:1760 + // FIXME: remove remaining dependence computation to computeDependence(). + auto Deps = E->getDependence(); cor3ntin wrote: > Maybe we should do that now, by passing `TemplateArgs` to

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

cor3ntin added inline comments. Comment at: clang/lib/AST/Expr.cpp:1760 + // FIXME: remove remaining dependence computation to computeDependence(). + auto Deps = E->getDependence(); Maybe we should do that now, by passing `TemplateArgs` to computeDependence?

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:625 auto D = E->getBase()->getDependence(); + D |= getDependenceInExpr(E->getMemberNameInfo()); + While implementing this patch I was following Richard's guide from https://gith

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Due to incorrect calculation false positive diagnostics were emitted. Fixes https://github.com/llvm/llvm-project/issues