[PATCH] D154543: [Support] Move StringExtras.h include from Error.h to Error.cpp

2023-07-08 Thread Elliot Goodrich via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39d8e6e22cd1: Add missing StringExtras.h includes (authored by IncludeGuardian). Changed prior to commit: https://reviews.llvm.org/D154543?vs=5382

[PATCH] D154543: [Support] Move StringExtras.h include from Error.h to Error.cpp

2023-07-07 Thread Elliot Goodrich via Phabricator via cfe-commits
IncludeGuardian updated this revision to Diff 538238. IncludeGuardian added a comment. Rebasing on `main` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154543/new/ https://reviews.llvm.org/D154543 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/BareMetal.cpp llv

[PATCH] D154543: [Support] Move StringExtras.h include from Error.h to Error.cpp

2023-07-07 Thread Elliot Goodrich via Phabricator via cfe-commits
IncludeGuardian added a comment. @MaskRay Thanks. I have updated the title to use `[Support]` and I will land the additional includes separately to the removal. This was very good advice last attempt as it I did have to revert the change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D