[PATCH] D15406: Add warning for attribute-cleanup on function parameter.

2017-12-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. I committed a different fix for this in r319555. https://reviews.llvm.org/D15406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [PATCH] D15406: Add warning for attribute-cleanup on function parameter.

2015-12-10 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. In http://reviews.llvm.org/D15406#307733, @rsmith wrote: > This looks fine to me, though it would be better to express the restricti

Re: [PATCH] D15406: Add warning for attribute-cleanup on function parameter.

2015-12-10 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. This looks fine to me, though it would be better to express the restrictions as a `SubjectList` on the attribute definition i

[PATCH] D15406: Add warning for attribute-cleanup on function parameter.

2015-12-09 Thread Nicholas Allegra via cfe-commits
comex created this revision. comex added a subscriber: cfe-commits. When a function parameter is declared `__attribute__((cleanup))`, neither Clang nor GCC actually executes the cleanup function, but Clang didn't warn about it. For the sake of compatibility, add a warning rather than making the