[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

MaskRay added a comment. > This is a breaking change since some SCLs might use .* or (abc|def) which are > supported regexes but not valid globs. Since we have just cut clang 16.x this > is a good time to make this change. This should be updated, too. 16.x => 17.x Repository: rG LLVM Github

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > [SpecialCaseList] Use Globs instead of Regex Since Glob is enabled under a non-default header `#!special-case-list-v2`, this subject should be changed. Repository: rG LLVM Github Monor

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis updated this revision to Diff 554089. ellis added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154014/new/ https://reviews.llvm.org/D154014 Files: clang/docs/SanitizerSpecialCaseList.rst clang/lib/Basic/ProfileList.cpp

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis updated this revision to Diff 548693. ellis added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154014/new/ https://reviews.llvm.org/D154014 Files: clang/docs/SanitizerSpecialCaseList.rst clang/lib/Basic/ProfileList.cpp

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis updated this revision to Diff 548349. ellis added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154014/new/ https://reviews.llvm.org/D154014 Files: clang/docs/SanitizerSpecialCaseList.rst clang/lib/Basic/ProfileList.cpp

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis updated this revision to Diff 542732. ellis added a comment. If `#!special-case-list-v2` is the first line in the special case list, then we will use globs to match patterns. Otherwise, we fall back to the original behavior of using regexes to match patterns. Once this feature is stable, a

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis added a comment. In D154014#4462886 , @MaskRay wrote: > In D154014#4461076 , @rupprecht > wrote: > >> In D154014#4457883 , @MaskRay >> wrote: >> This is a bre

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

phosek added a comment. If we want to support both regular expressions and glob patterns permanently, then a solution like `#!regex` or `#!glob` is likely the way to go. If we want to allow soft-transition, then we could do something like `#!special-case-list-v2`, where v1 would support regular

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

MaskRay added a comment. In D154014#4461076 , @rupprecht wrote: > In D154014#4457883 , @MaskRay wrote: > >>> This is a breaking change since some SCLs might use .* or (abc|def) which >>> are supported regexes but

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis updated this revision to Diff 536003. ellis added a comment. Fix memory bug and add TODO about a regex/glob config. Lets wait for others to comment before I put work into this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154014/new/ https:

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis added a comment. In D154014#4461076 , @rupprecht wrote: > In D154014#4457883 , @MaskRay wrote: > >>> This is a breaking change since some SCLs might use .* or (abc|def) which >>> are supported regexes but n

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

rupprecht added a comment. In D154014#4457883 , @MaskRay wrote: >> This is a breaking change since some SCLs might use .* or (abc|def) which >> are supported regexes but not valid globs. Since we have just cut clang 16.x >> this is a good time to make t

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

MaskRay added a comment. > This is a breaking change since some SCLs might use .* or (abc|def) which are > supported regexes but not valid globs. Since we have just cut clang 16.x this > is a good time to make this change. My user has some ignore lists, but there is no `^[a-z]+:.*\(` or `^[a-z]

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. ellis edited the summary of this revision. ellis added reviewers: MaskRay, phosek, vitalybuka, samsonov, hctim. ellis updated this revision to Diff 535560. ellis added a comment. ellis published this rev