[PATCH] D153881: Create diagnostic group for definition deprecation warning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0697a1cb0b5: Create diagnostic group for definition deprecation warning (authored by nuriamari, committed by aaron.ballman). Changed prior to commi

[PATCH] D153881: Create diagnostic group for definition deprecation warning

nuriamari added a comment. In D153881#4497041 , @aaron.ballman wrote: > LGTM! Do you need me to land this on your behalf? If so, what name and email > address would you like me to use for patch attribution? (If I'm landing it, I > can fix up the releas

[PATCH] D153881: Create diagnostic group for definition deprecation warning

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need me to land this on your behalf? If so, what name and email address would you like me to use for patch attribution? (If I'm landing it, I can fix up the release

[PATCH] D153881: Create diagnostic group for definition deprecation warning

nuriamari added inline comments. Comment at: clang/docs/ReleaseNotes.rst:373 (`#13920: `_) +- A new diagnostic warning group ``deprecated-redundant-constexpr-static-def`` is + added. This is to be used to control warnings ab

[PATCH] D153881: Create diagnostic group for definition deprecation warning

nuriamari updated this revision to Diff 538751. nuriamari added a comment. - Create entry in release notes - Move test to appropriate location - Expand test to include `const` warning controlled in the same warning group Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D153881: Create diagnostic group for definition deprecation warning

aaron.ballman added a comment. In D153881#4468597 , @nuriamari wrote: > In D153881#4467127 , @aaron.ballman > wrote: > >> I think it's a bit odd that we'd leave `const` under `-Wdeprecated` but >> separate `cons

[PATCH] D153881: Create diagnostic group for definition deprecation warning

nuriamari added a comment. In D153881#4467127 , @aaron.ballman wrote: > I think it's a bit odd that we'd leave `const` under `-Wdeprecated` but > separate `constexpr` out into its own warning flag, but I'm also not opposed. Would moving both const and

[PATCH] D153881: Create diagnostic group for definition deprecation warning

aaron.ballman added a comment. I think it's a bit odd that we'd leave `const` under `-Wdeprecated` but separate `constexpr` out into its own warning flag, but I'm also not opposed. Can you explain the need a bit more though? I think our belief was that silencing this diagnostic was pretty trivi

[PATCH] D153881: Create diagnostic group for definition deprecation warning

nuriamari created this revision. Herald added a project: All. nuriamari added reviewers: bruno, aaron.ballman. nuriamari added inline comments. nuriamari published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Comment at: clang/t