[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG7aafea001282: [llvm][Support] Deprecate llvm::writeFileAtomically API (authored by hokein). Repository: r

[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

avl accepted this revision. avl added a comment. This revision is now accepted and ready to land. this LGTM, assuming D154329 is landed. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153740/new/ https:

[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein marked an inline comment as done. hokein added a comment. Now this patch only contains the removal part of the API (I have cleaned all usages of `writeFileAtomically` API, except a remaining one in lldb https://reviews.llvm.org/D154329). Comment at: lldb/tools/lldb-ser

[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein updated this revision to Diff 536698. hokein added a comment. Restrict the patch to only remove the writeFileAtomically API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153740/new/ https://reviews.llvm.org/D153740 Files: llvm/include/llv

[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein added a comment. In D153740#4448408 , @avl wrote: > added @jkorous who originally added llvm::writeFileAtomically. > >> Let me know what you think about it -- I considered keeping the >> llvm::writeFileAtomically and migrating its underlying imple

[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

avl added a reviewer: jkorous. avl added a subscriber: jkorous. avl added a comment. added @jkorous who originally added llvm::writeFileAtomically. > Let me know what you think about it -- I considered keeping the > llvm::writeFileAtomically and migrating its underlying implementation to > llvm

[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein added a comment. Herald added a subscriber: JDevlieghere. Let me know what you think about it -- I considered keeping the `llvm::writeFileAtomically` and migrating its underlying implementation to `llvm::writeToOutput`, but it doesn't seem to worth, there are only 4 in-tree usages of thi

[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein created this revision. hokein added a reviewer: avl. Herald added subscribers: ormris, kadircet, arphaman, steven_wu, hiraditya. Herald added a project: All. hokein requested review of this revision. Herald added projects: clang, LLDB, LLVM, clang-tools-extra. Herald added subscribers: llvm-