This revision was automatically updated to reflect the committed changes.
Closed by commit rL256150: [scan-view] replace deprecated optparse with
argparse (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D15370?vs=42636&id=43358#toc
Repository:
rL LLVM
http://reviews.l
omtcyf0 updated this revision to Diff 42636.
omtcyf0 added a comment.
Added tool description.
http://reviews.llvm.org/D15370
Files:
tools/scan-view/bin/scan-view
Index: tools/scan-view/bin/scan-view
===
--- tools/scan-view/bin/s
zaks.anna added a comment.
Overall, looks good!
Comment at: tools/scan-view/bin/scan-view:94
@@ +93,3 @@
+import argparse
+parser = argparse.ArgumentParser()
+parser.add_argument("root", metavar="", type=str)
Please, add the tool description, like "T
jroelofs added a comment.
Looks reasonable to me from a "I haven't actually tried it with this patch"
perspective.
http://reviews.llvm.org/D15370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
djasper added a comment.
I know nothing about this code.
http://reviews.llvm.org/D15370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyf0 created this revision.
omtcyf0 added a reviewer: ddunbar.
omtcyf0 added a subscriber: cfe-commits.
scan-view migrated from optparse deprecated Python module to its replacement
(argparse) and resolved few conflicts with pep8
http://reviews.llvm.org/D15370
Files:
tools/scan-view/bin/sca
