Thank you for fixing this!
On Fri, Jan 22, 2016 at 12:30 PM, Nico Weber wrote:
> I implemented Reid's suggestion in 258545. I tested that the test runs and
> passes when the DIA SDK is around (this is usually the case), and doesn't
> run when it isn't.
>
> On Thu, Jan 21, 2016 at 2:09 PM, Alexey
I implemented Reid's suggestion in 258545. I tested that the test runs and
passes when the DIA SDK is around (this is usually the case), and doesn't
run when it isn't.
On Thu, Jan 21, 2016 at 2:09 PM, Alexey Samsonov wrote:
> On Thu, Jan 21, 2016 at 10:58 AM, Reid Kleckner wrote:
>
>> On Thu, J
On Thu, Jan 21, 2016 at 10:58 AM, Reid Kleckner wrote:
> On Thu, Jan 21, 2016 at 10:47 AM, Nico Weber wrote:
>
>> Oh, ok, let's not depend on lld then. So, we need to either determine if
>>> DIA SDK is available at compiler-rt configure time, or teach
>>> llvm-symbolizer.exe to tell us that (as
On Thu, Jan 21, 2016 at 10:47 AM, Nico Weber wrote:
> Oh, ok, let's not depend on lld then. So, we need to either determine if
>> DIA SDK is available at compiler-rt configure time, or teach
>> llvm-symbolizer.exe to tell us that (as we support standalone compiler-rt
>> build)...
>>
>
> Maybe the
On Thu, Jan 21, 2016 at 1:44 PM, Alexey Samsonov wrote:
>
> On Thu, Jan 21, 2016 at 10:20 AM, Nico Weber wrote:
>
>> On Thu, Jan 21, 2016 at 1:19 PM, Alexey Samsonov
>> wrote:
>>
>>>
>>> On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber
>>> wrote:
>>>
thakis added a comment.
After so
On Thu, Jan 21, 2016 at 10:20 AM, Nico Weber wrote:
> On Thu, Jan 21, 2016 at 1:19 PM, Alexey Samsonov
> wrote:
>
>>
>> On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber wrote:
>>
>>> thakis added a comment.
>>>
>>> After some more debugging, the only thing in this test that's still
>>> faiilng on W
On Thu, Jan 21, 2016 at 1:19 PM, Alexey Samsonov wrote:
>
> On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber wrote:
>
>> thakis added a comment.
>>
>> After some more debugging, the only thing in this test that's still
>> faiilng on Windows is the "unsigned-integer-overflow:do_overflow"
>> suppressi
On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber wrote:
> thakis added a comment.
>
> After some more debugging, the only thing in this test that's still
> faiilng on Windows is the "unsigned-integer-overflow:do_overflow"
> suppression -- when llvm-symbolizer gets symbols from PDBs it currently
> req
thakis added a comment.
After some more debugging, the only thing in this test that's still faiilng on
Windows is the "unsigned-integer-overflow:do_overflow" suppression -- when
llvm-symbolizer gets symbols from PDBs it currently requires the DIA SDK. If
that's not found at cmake time, then llv
hans added a subscriber: hans.
hans added a comment.
I tried to printf debug with this patch:
Index: lib/sanitizer_common/sanitizer_suppressions.cc
===
--- lib/sanitizer_common/sanitizer_suppressions.cc (revision 257931)
thakis added a comment.
I re-disabled the test in 257952.
Repository:
rL LLVM
http://reviews.llvm.org/D15363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis added a comment.
I figured out the difference. If I set up my environment by running
`setenv.cmd` in the windows sdk, the test fails. If I set it up by running
`vcvarsall.bat`, the test succeeds. Not clear yet why. But with the setenv.cmd
setup, the asan suppression test fails too.
Rep
thakis added a comment.
In http://reviews.llvm.org/D15363#321941, @samsonov wrote:
> Interesting. Do we run test/asan/TestCases/suppressions-interceptor.cc on
> Windows? Seems so: I don't see an XFAIL there, and it also uses
> suppressions, but with single quote, followed by double quote:
>
> %
thakis added a comment.
This test is failing again when it runs as part of llvm's tests when I
build a clang package for chromium. It passes when I run it in my regular
llvm build directory (where I ran it to test my "fix") -- this explains why
the fix didn't work when I tried it in the chrome cas
rnk added a subscriber: rnk.
rnk added a comment.
In http://reviews.llvm.org/D15363#321941, @samsonov wrote:
> Interesting. Do we run test/asan/TestCases/suppressions-interceptor.cc on
> Windows? Seems so: I don't see an XFAIL there, and it also uses
> suppressions, but with single quote, follo
Interesting. Do we run test/asan/TestCases/suppressions-interceptor.cc on
Windows? Seems so: I don't see an XFAIL there, and it also uses
suppressions, but with single quote, followed by double quote:
%env_asan_opts=suppressions='"%t.supp"'
Why does it work there?
On Tue, Dec 22, 2015 at 4:35 PM
thakis added a comment.
I've looked at it some, and couldn't find a way of escaping quotes that lit
doesn't strip but that ubsan accepts.
'"c:\foo"' gets its quotes stripped by lit, so does """c:\foo""". \"c:\foo\"
confuses lit enough that it tries to call lit.util.warning() which doesn't
exis
thakis added a comment.
And this in turn is because env strips the quotes:
C:\src\chrome\src\third_party\llvm-bootstrap>env
UBSAN_OPTIONS=halt_on_error=1:suppressions="C:\src\chrome\src\third_party\llvm-bootstrap\projects\compiler-rt\test\ubsan\Standalone-x86_64\TestCases\Integer\Output\suppress
thakis added a comment.
It's because FlagParser::is_space() considers ':' as a space, so it thinks c:\
ends after the c and then starts parsing another flag at the \.
Fix ideas: Don't treat : as space while in quotes, or use ; as separator on
Windows.
Repository:
rL LLVM
http://reviews.llv
thakis added a comment.
Here's the error (I still don't know how to run single tests through lit,
though):
C:\src\chrome\src\third_party\llvm-bootstrap>env
UBSAN_OPTIONS=halt_on_error=1:suppressions="C:\src\chrome\src\third_party\llvm-bootstrap\projects\compiler-rt\test\ubsan\Standalone-x86_64\
thakis added a subscriber: thakis.
Comment at: compiler-rt/trunk/test/ubsan/TestCases/Integer/suppressions.cpp:1
@@ +1,2 @@
+// RUN: %clangxx -fsanitize=integer -g0 %s -o %t
+
This test fails on Windows. I tried to debug, but the usual way to run tests
seems to n
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256018: [UBSan] Implement runtime suppressions (PR25066).
(authored by samsonov).
Changed prior to commit:
http://reviews.llvm.org/D15363?vs=42250&id=43254#toc
Repository:
rL LLVM
http://reviews.llv
kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D15363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
samsonov added a comment.
Kostya, PTAL. IIRC it was your feature request :)
http://reviews.llvm.org/D15363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
samsonov added a comment.
Richard, could you take a look at this?
http://reviews.llvm.org/D15363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
samsonov created this revision.
samsonov added reviewers: rsmith, kcc.
samsonov added a subscriber: cfe-commits.
Add the ability to suppress UBSan reports for files/functions/modules
at runtime. The user can now pass UBSAN_OPTIONS=suppressions=supp.txt
with the contents of the form:
signed-intege
26 matches
Mail list logo
