[PATCH] D153491: [dataflow] Avoid copying environment

xazax.hun added a comment. In D153491#4445051 , @ymandel wrote: > In D153491#4443704 , @xazax.hun > wrote: > >> This sounds extremely error-prone to me. In case copying the analysis state >> has side effects lik

[PATCH] D153491: [dataflow] Avoid copying environment

gribozavr2 added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153491/new/ https://reviews.llvm.org/D153491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D153491: [dataflow] Avoid copying environment

sammccall added a comment. In D153491#4445051 , @ymandel wrote: > In D153491#4443704 , @xazax.hun > wrote: > >> This sounds extremely error-prone to me. In case copying the analysis state >> has side effects lik

[PATCH] D153491: [dataflow] Avoid copying environment

ymandel added a comment. In D153491#4443704 , @xazax.hun wrote: > This sounds extremely error-prone to me. In case copying the analysis state > has side effects like this, I would argue we want such operations to be > really explicit. What do you think?

[PATCH] D153491: [dataflow] Avoid copying environment

xazax.hun added a comment. This sounds extremely error-prone to me. In case copying the analysis state has side effects like this, I would argue we want such operations to be really explicit. What do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D153491: [dataflow] Avoid copying environment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51717c93e749: [dataflow] Avoid copying environment (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D153491: [dataflow] Avoid copying environment

sammccall created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This appears to be just an accidental copy r