michaelplatings updated this revision to Diff 533566.
michaelplatings added a comment.
Apply @DavidSpickett's suggestions.
@peter.smith since the warning is only emitted in specific cases that we can be
say with a high degree of confidence are incorrect I think it's accurate to say
"invalid". I
DavidSpickett added a comment.
> Perhaps "Unrecognized environment for , did you mean
> -none-"
I like explaining it like this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153430/new/
https://reviews.llvm.org/D153430
_
peter.smith added a comment.
I can confirm that we have seen several users of the LLVM Embedded Toolchain
for Arm that work on both AArch64 and Arm make this mistake as it is easy to
just alter an example triple by substituting the first element.
Given that this is a warning, invalid is perhaps
DavidSpickett added a comment.
Please tag the commit title with the subproject, `[clang]` in this case. If
only to help your friendly neighborhood buildbot minder.
I'd maybe go with "Did you mean" instead of "try" but only because the first
thing I think is well if I try it what will I get. The
michaelplatings created this revision.
michaelplatings added reviewers: peter.smith, DavidSpickett.
Herald added subscribers: abidh, kristof.beyls.
Herald added a project: All.
michaelplatings requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, MaskRay.
Herald ad
